Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues to fix #276

Closed
12 of 14 tasks
JonasFrey96 opened this issue Aug 29, 2023 · 3 comments
Closed
12 of 14 tasks

Small issues to fix #276

JonasFrey96 opened this issue Aug 29, 2023 · 3 comments

Comments

@JonasFrey96
Copy link
Collaborator

JonasFrey96 commented Aug 29, 2023

  • Within all extraction scripts make the configuration nice and add testing for it
  • Rework the parsing of the dimension of the input features from DINO
  • If mean kernel doesnt work in DINO remove all the code for it
  • Implement the ConfidenceGenerator in AnomalLoss - replace the mean calculation
  • In traversabilitzy estimator remove unused dependencies and remove all ros dependencies
  • Publish the reprojection mask within the learning node in the imagefeat_callback only if debug is ture
  • Check the implementation for the pervious nodes if this is needed
  • Check if the loading of the different models works
  • Remove in all files unnecessary default params
  • Implement confidence generator together with the existing clipping in the loss
  • Remove unnecessary python library dependencies
  • Refactor the configuration - make the dataclass contain all variables that are also set via the ros parameters otherwise it is very hard to keep track.
  • Remove the hierarchical learning folder the flatter structure improves readability
  • Update in robot file reload_default_params to False
@RobinSchmid7 RobinSchmid7 linked a pull request Aug 30, 2023 that will close this issue
6 tasks
@RobinSchmid7
Copy link
Collaborator

Mean kernel does not seem to help a lot, seems to create more noise in the lower half of the image. Remove part of this code.

@RobinSchmid7
Copy link
Collaborator

  • Add namespaces to topics

@RobinSchmid7
Copy link
Collaborator

RobinSchmid7 commented Aug 31, 2023

  • Implement correct stopping of ros nodes when running robot.launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants