Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell history not being persisted correctly #52

Open
afiore opened this issue Sep 24, 2019 · 0 comments
Open

Shell history not being persisted correctly #52

afiore opened this issue Sep 24, 2019 · 0 comments

Comments

@afiore
Copy link
Contributor

afiore commented Sep 24, 2019

👋 Hi there,

While using the shell subcommand, I have noticed that the query history doesn't seem to be persisted correctly.

Expected behaviour

  • Like other interactive shells, I would expect the lenses-cli shell to append to the history file both valid and invalid queries.
  • Most important, I would expect the shell to reload the history on startup and allow me to cycle through all my recent queries using the arrow keys.

Steps to reproduce

I observed the behaviour below on a local build of: dcbcf0b:

lenses-sql> show tables;
// output omitted
  • Run second query:
lenses-sql>select * from cc_data limit 1;
... output omitted
  • Hit Crtl+D and exit the shell
  • Inspect the history file:
cat ~/.lenses/history
select * from cc_data limit 1; select * from cc_data limit 1;% 

Note that:

  • the first query has not been persisted, and will not be available when re-running the command
  • the last query is repeated twice
@afiore afiore changed the title Shell history not being preserved correctly Shell history not being persisted correctly Sep 24, 2019
lanbotdeployer pushed a commit that referenced this issue Dec 14, 2020
fix(CLI): DATA-961/ Add Datasets field for Creating, Updating Policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant