Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prior functionality #60

Open
3 tasks done
raphaelshirley opened this issue Apr 3, 2024 · 0 comments · May be fixed by #153
Open
3 tasks done

Improve prior functionality #60

raphaelshirley opened this issue Apr 3, 2024 · 0 comments · May be fixed by #153
Assignees
Labels
enhancement New feature or request

Comments

@raphaelshirley
Copy link
Member

raphaelshirley commented Apr 3, 2024

As part of the AGN development we want to include addtional prior functionality. As part of this we would like to move the existing prior functionality (abs mag and n of z) into a distinct prior class.

We would also like the prior to be overwritten on an object by object basis via Python. Experiments show this can slow down openmp so we need a system for computing priors outside the openmp loops and or a more general n of z function which can be overwritten via Python.

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@raphaelshirley raphaelshirley added the enhancement New feature or request label Apr 3, 2024
@raphaelshirley raphaelshirley self-assigned this Apr 3, 2024
@raphaelshirley raphaelshirley linked a pull request Jun 5, 2024 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant