Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update MaxWriteBufferSize comment and MaxWriteBufferSize default check #427

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: update MaxWriteBufferSize comment and MaxWriteBufferSize default check #427

merged 1 commit into from
May 7, 2024

Conversation

byene0923
Copy link
Collaborator

@byene0923 byene0923 commented May 7, 2024 •
edited
Loading

hello，i have read the talk in issues 264，but I found comment and check for MaxWriteBufferSize may be not right？I have done follow things。

  1. update outdated comment for MaxWriteBufferSize
  2. set DefaultMaxWriteBufferSize 0 by default
  3. add negative number check for MaxWriteBufferSize in NewEngine()

@byene0923
feat:
cf44117 
1. update outdated comment for MaxWriteBufferSize
2. set DefaultMaxWriteBufferSize 0 by default
3. add negative number check for MaxWriteBufferSize in NewEngine
@lesismal lesismal merged commit d31ce3e into lesismal:master May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byene0923 @lesismal