Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access your data for all websites permission? #4

Open
meglio opened this issue Apr 3, 2021 · 4 comments
Open

Access your data for all websites permission? #4

meglio opened this issue Apr 3, 2021 · 4 comments

Comments

@meglio
Copy link

meglio commented Apr 3, 2021

Dear plugin author,

Can you make it work without the "Access your data for all websites" permission?

-- Thanks, Anton

@lhall-amphibee
Copy link
Owner

Hello Anton,

The plugin needs the permissions to know the browsed URL and place the cookie.

If it's a privacy issue, rest assured that the plugin doesn't share information with anyone (including myself)

@meglio
Copy link
Author

meglio commented Apr 6, 2021

Yeah I can see this in the source code, but there is still an issue: once I grant the permission, it is there for all future plugin updates. Times goes and the project can get a new maintainer/owner with bad intentions. This actually happens quite often with various extensions, even with very popular ones with 1M+ active installations.

Is there any other way for the plugin to operate and still be useful without accessing the URL and placing the cookie? Something like a middleware that cannot access the full page content, but just alter cookie content. Or add a GET variable to the URL instead, which should work equally well with XDEBUG. What do you think? -- Many thanks

@lhall-amphibee
Copy link
Owner

That's a good point.

I'll try to think of something, but maybe you don't actually need this plugin at all ? Xdebug should work with a GET parameter out of the box with some config :

Using a GET parameter
If you want to debug a script started through a web browser, simply add XDEBUG_SESSION_START=session_name as parameter to the URL. Instead of using a GET parameter, you can also set XDEBUG_SESSION_START as a POST parameter, or through a cookie named XDEBUG_SESSION. Refer to the next section to read on how debug sessions work from within a browser window.

https://2.xdebug.org/docs/remote

Maybe this could work for you ?

@meglio
Copy link
Author

meglio commented Apr 9, 2021

Maybe this could work for you ?

Yes and no. While I can definitely add a GET parameter to the URL in my browser, I can't add that to all the API/Ajax calls, dynamic .js and .css file URLs, etc.

So, just a single click to turn xdebug ON/OFF would still be the best experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants