Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Send for Symbolizer? #930

Open
d-e-s-o opened this issue Dec 19, 2024 · 2 comments
Open

Impl Send for Symbolizer? #930

d-e-s-o opened this issue Dec 19, 2024 · 2 comments

Comments

@d-e-s-o
Copy link
Collaborator

d-e-s-o commented Dec 19, 2024

In some contexts it would be great to have Symbolizer (and, perhaps slightly less importantly, Inspector and Normalizer) be Send. I prototyped that here https://github.com/d-e-s-o/blazesym/compare/main..topic/symbolizer-send but it requires usage of a bunch of more heavy weight synchronization primitives. It's an open question whether we want to pay that price.

@d-e-s-o
Copy link
Collaborator Author

d-e-s-o commented Dec 19, 2024

I think one thing we could do to eliminate the need for some of those synchronization primitives would be to make the caching we do explicit in method signatures. That is, symbolize(&self, [...]) -> symbolize(&mut self, [...]). Not sure what negative trickle down effects that would have on clients.

@danielocfb
Copy link
Collaborator

Not sure what negative trickle down effects that would have on clients.

One of the obvious downsides would be that, because we effectively return borrowed data from Symbolizer::symbolize, this data would have to be dropped (or cloned) before to the next call to symbolize. I think that disqualifies this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants