Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Debian 10 out-of-the-box #11

Open
rosenfeld opened this issue Mar 12, 2020 · 3 comments
Open

Support Debian 10 out-of-the-box #11

rosenfeld opened this issue Mar 12, 2020 · 3 comments

Comments

@rosenfeld
Copy link

Hi, currently I have to set the library_path for getting it to work with Debian 10:

TidyFFI.library_path = Dir['/usr/lib/x86_64-linux-gnu/libtidy.so*'].first

Maybe it would be interesting to add support for Debian 10 out-of-the-box, since it's a very popular Linux distribution.

Currently this is the path tried by tidy_ffi:

https://github.com/libc/tidy_ffi/blob/master/lib/tidy_ffi/lib_tidy.rb#L8

  LIB_NAME = 'tidy'.freeze
  PATHS = Array([LIB_NAME] + Dir['/{opt,usr}/{,local/}lib{,64}/libtidy{,-*}.{dylib,so*}']).freeze

Maybe we could try changing it to:

  LIB_NAME = 'tidy'.freeze
  PATHS = Array([LIB_NAME] + Dir['/{opt,usr}/{,local/}lib{,64}/{,x86_64-linux-gnu/}libtidy{,-*}.{dylib,so*}']).freeze

I didn't submit a PR because I'm not sure there would be a better way to test for such paths.

Thanks for tidy_ffi!

@simi
Copy link

simi commented Apr 13, 2020

👋

ℹ️ This problem is for example present on official ruby docker image (in my case Ruby 2.5.7) since it is Debian 10 based.

@rosenfeld would you mind to open pull request as you suggested?

@rosenfeld
Copy link
Author

Sure, I will download a Docker image based on Debian 10 and once I make sure the suggested patch works, I'll send the pull request.

rosenfeld added a commit to rosenfeld/tidy_ffi that referenced this issue Apr 14, 2020
@libc
Copy link
Owner

libc commented May 5, 2020

Hello,

I just released version 1.0.1 that should fix this problem. Lemme know if it doesn't.

Thank you for reporting this and submitting the Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants