DeleteRecords not remove the record...

[mcarbonneaux]

when try to remove record by the name

	deletedRecs, err := provider.DeleteRecords(ctx, zone, []libdns.Record{
		{
			Name: "sub",
		},
	})

in the DeleteRecords method :

rfc2136/provider.go

Line 101 in ec2c145

rr, err := recordToRR(rec, zone)

recordToRR return nil RR...

and crash at

rfc2136/provider.go

Line 105 in ec2c145

msg.Remove([]dns.RR{rr})

when i add type:

deletedRecs, err := provider.DeleteRecords(ctx, zone, []libdns.Record{
{
	Name: "sub",
	Type: "A",
},
})

they not crash but not remove the record...

[mcarbonneaux]

is not because you use Remove
https://github.com/miekg/dns/blob/b18c05cc13607aacb056a0f483e0f4c9229a1d67/update.go#L102

in place of

https://github.com/miekg/dns/blob/b18c05cc13607aacb056a0f483e0f4c9229a1d67/update.go#L92
RemoveName ?