Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

False positive validating "Missing wiki links" #4

Open
ignasi35 opened this issue Mar 22, 2017 · 0 comments
Open

False positive validating "Missing wiki links" #4

ignasi35 opened this issue Mar 22, 2017 · 0 comments

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Mar 22, 2017

See lagom/lagom#615

  • File was named: IntellijMaven.md.
  • Link to file was intellijMaven (lowercase i)

Expected

Running markdownValidateDocs fails

[error] Could not find link intellijMaven at /Users/ignasi/git/projects/lightbend/lagom/docs/manual/java/gettingstarted/WhatsNext.md:13
[error] * [[Import an existing Maven project into Intellij|intellijMaven]]
[error]                                                    ^
[info] [fail] Missing wiki links test (1 errors)

Actual

Running markdownValidateDocs passes

[info] [pass] Missing wiki links test

Bug seems to be in https://github.com/playframework/play-doc/blob/master/src/main/scala/play/doc/FileRepository.scala#L93 (uses equalsIgnoreCase instead of equals) but changing that could have side effects in other validations such as Duplicate markdown file name test

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants