Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MAE to use timm ViT #1364

Closed
2 tasks done
guarin opened this issue Aug 25, 2023 · 4 comments
Closed
2 tasks done

Refactor MAE to use timm ViT #1364

guarin opened this issue Aug 25, 2023 · 4 comments

Comments

@guarin
Copy link
Contributor

guarin commented Aug 25, 2023

We want to refactor the MAE code to use the timm ViT backbone instead of torchvision ViT. The reason for it is that torchvision ViT is too different from the ViT used in MAE and doesn't support all the features we need. See #1263 for some issues. Refactoring the code allows use to use the same backbone as was used in the original MAE code.

Ideally the refactoring allows us to be relatively flexible with the backbone we use so that users are free to use different ViT backbones.

Todo

  • Refactor MAE code to use timm ViT backbone
  • Make sure any timm imports are optional and do not break the package. We want to keep timm dependency optional, see Add timm dependency? #1301
This was referenced Aug 25, 2023
@guarin guarin added this to Use TIMM Aug 25, 2023
@guarin guarin moved this to Todo in Use TIMM Aug 25, 2023
@radiradev
Copy link
Contributor

Hi, I am working on implementing this, should be able to submit a pull request soon.

@guarin
Copy link
Contributor Author

guarin commented Jul 26, 2024

Hi @radiradev! This issue seems to have gotten lost, the MAE examples are in the meantime already updated to use TIMM ViT. See the docs and the benchmark. Is there something particular that you have found that is still missing? Otherwise I would close this issue.

One thing we didn't yet have time to do is #1367 (I-JEPA with TIMM ViT). Let us know if you would be interested in working on that.

@radiradev
Copy link
Contributor

Hi @guarin, I commented on the wrong issue. (I have started working on #1367).

Feel free to close this one.

@guarin
Copy link
Contributor Author

guarin commented Jul 26, 2024

Completed in #1461

@guarin guarin closed this as completed Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Use TIMM Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants