Provide an API to interact with CalDav server #1465

HoussemNasri · 2025-01-15T13:13:28Z

Closes #1462

TODO:

Use the If-Match header not to update calendar objects that changed since they have been retrieved.

tmail-backend/tmail-third-party/openpaas/pom.xml

tmail-backend/apps/memory/src/main/java/com/linagora/tmail/james/app/MemoryServer.java

...end/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/card/CardDavHandler.java

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

...y/openpaas/src/main/java/com/linagora/tmail/dav/request/GetCalendarByEventIdRequestBody.java

...ackend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/xml/CalendarData.java

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

...il-third-party/openpaas/src/main/java/com/linagora/tmail/configuration/DavConfiguration.java

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

HoussemNasri · 2025-01-22T13:45:49Z

Note: For some reason, I had to force push. Anyway, the only new commit is c448e55.

tmail-backend/tmail-third-party/openpaas/pom.xml

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

...kend/tmail-third-party/openpaas/src/test/java/com/linagora/tmail/dav/DavServerExtension.java

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

chibenwa · 2025-01-24T15:29:56Z

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

+                    .switchIfEmpty(Mono.fromRunnable(
+                        () -> LOGGER.trace("VEvent '{}' was not found in Calendar '{}'.", eventUid, calendarURI)))


ReactorUtils.logAsMono in order to be more idiomatic.

I couldn't because logAsMono is not generic. It returns Mono<Void> while we need Mono<Calendar>.

ReactorUtils.logAsMono(() -> LOGGER...).thenReturn(calendar) ???

But then we need to thenReturn(null). In my opinion, unless we make logAsMono generic, this is the best syntax we can achieve.

https://projectreactor.io/docs/core/release/api/reactor/util/context/Context.html

Yes but it looses context. So please comply.

Okay, done. Should we open a PR in James to make logAsMono generic?

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

chibenwa · 2025-01-24T15:36:18Z

An alternative solution is we use this fork https://github.com/nmondal/spark-11/blob/master/pom.xml

To be adopted at the James scale if needed. Feel free to post an email about this onto [email protected].

chibenwa · 2025-01-27T13:21:10Z

@HoussemNasri you need to rebase in order to solve conflict

chibenwa · 2025-01-27T16:35:47Z

Use the If-Match header not to update calendar objects that changed since they have been retrieved.

Basic rule when doing optimistic transactions:

This will need to be retried.

THe total number of retries need to be bounded and low: 5 max....

chibenwa · 2025-01-27T20:43:35Z

Reviewed.

There is still a merge conflict over here!

chibenwa · 2025-01-28T12:03:43Z

Can we write a clean history here with ISSUE-XXX as a commit message prefix?

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

...kend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClientException.java

… operations - Implemented parsing of DAV multistatus responses - Implemented user calendar discovery via PROPFIND requests - Added WireMock for testing PROPFIND and REPORT methods as mockserver does not support custom HTTP methods.

- Because we use a mock server

chibenwa · 2025-01-29T14:13:00Z

tmail-backend/tmail-third-party/openpaas/pom.xml

+        <dependency>
+            <groupId>org.wiremock</groupId>
+            <artifactId>wiremock-standalone</artifactId>
+            <version>3.10.0</version>


Forgotten <scope>test</scope>

Just to summarize the current issue with dependencies:

Wiremock imports a library called json-schema-validator.

This library is being imported by mockserver too but uses an old and uncompatible version.

At class-load time, this library reads a localization JSON file, parses it, and caches the object in memory.

This file is not stored under a package name but rather stored in the root of the resources folder.

This creates a conflict between the two localization files imported by Wiremock and Mockserver and one would override the other.

As the versions of the library imported are incompatible, using the code of version A to read the config of version B fails.

The two versions can co-exist because the wiremock library is imported as standalone: https://github.com/wiremock/wiremock/blob/f91326573547a90fd143252d77961eaa0345dbb1/build.gradle#L284

Ok shading dependencies is really OK in this context.

chibenwa · 2025-01-29T14:51:03Z

tmail-backend/jmap/extensions-api/pom.xml

+        <dependency>
+            <groupId>org.mnode.ical4j</groupId>
+            <artifactId>ical4j</artifactId>
+            <version>3.2.9</version>


Count on me for forgetting to update the dependency, resulting in a delta, and non-previsible behaviour because of non allignement with Apache James.

We should:

Add ical4j in james project management and use it within the scope of Apache James projects

And then remove specific versions of Tmail so that we align with James BOM (bill of material)

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java

Arsnael · 2025-02-03T04:42:30Z

[ERROR] Crashed tests:
[ERROR] com.linagora.tmail.james.app.MemoryServerWithOpenPaasConfiguredTest$DavConfigured

chibenwa reviewed Jan 15, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/pom.xml Outdated Show resolved Hide resolved

chibenwa reviewed Jan 15, 2025

View reviewed changes

tmail-backend/apps/memory/src/main/java/com/linagora/tmail/james/app/MemoryServer.java Show resolved Hide resolved

chibenwa reviewed Jan 15, 2025

View reviewed changes

...end/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/card/CardDavHandler.java Outdated Show resolved Hide resolved

HoussemNasri force-pushed the refactor-dav-client branch from 5dc96d3 to 0df173e Compare January 20, 2025 11:37

chibenwa reviewed Jan 20, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 20, 2025

View reviewed changes

chibenwa reviewed Jan 21, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 21, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

HoussemNasri force-pushed the refactor-dav-client branch from 7c99cbe to c448e55 Compare January 22, 2025 13:43

chibenwa reviewed Jan 22, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/pom.xml Outdated Show resolved Hide resolved

chibenwa reviewed Jan 22, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 22, 2025

View reviewed changes

...kend/tmail-third-party/openpaas/src/test/java/com/linagora/tmail/dav/DavServerExtension.java Outdated Show resolved Hide resolved

HoussemNasri marked this pull request as ready for review January 24, 2025 13:24

chibenwa reviewed Jan 24, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 24, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

HoussemNasri force-pushed the refactor-dav-client branch from b70ba7e to a0ab5f9 Compare January 28, 2025 09:42

chibenwa reviewed Jan 28, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 28, 2025

View reviewed changes

...kend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClientException.java Outdated Show resolved Hide resolved

HoussemNasri added 5 commits January 29, 2025 12:05

[ISSUE-1462] Test CalDav specific API methods

61533b9

[ISSUE-1462] Escape XML characters to avoid security vulnerability

3adf1e3

[ISSUE-1462] Introduce DavClient#updateCalendarObject

c3806ed

[ISSUE-1462] Remove dependency on jmap-extensions

231055f

HoussemNasri added 3 commits January 29, 2025 12:06

[ISSUE-1462] Rename 'CardDav' to 'Dav' when needed

7aa8e62

[ISSUE-1462] Retry calendar object update on server PRECONDITION_FAILED

f3b3405

[ISSUE-1462] Use low retry-backoff value when running tests

ced7adc

- Because we use a mock server

HoussemNasri force-pushed the refactor-dav-client branch from f21f149 to ced7adc Compare January 29, 2025 11:11

[ISSUE-1462] Protect against XML external entity attacks

d4c0103

chibenwa reviewed Jan 29, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

chibenwa reviewed Jan 29, 2025

View reviewed changes

tmail-backend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/dav/DavClient.java Outdated Show resolved Hide resolved

HoussemNasri added 3 commits January 30, 2025 13:11

[ISSUE-1462] Be more resilient against invalid use calendars

48d632b

[ISSUE-1462] Identify user calendar collections based on d:resourcetype

287a5c4

[ISSUE-1462] Use logAsMono to not lose reactive context

2e6d0d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide an API to interact with CalDav server #1465

Provide an API to interact with CalDav server #1465

HoussemNasri commented Jan 15, 2025 •

edited

Loading

HoussemNasri commented Jan 22, 2025

chibenwa Jan 24, 2025

HoussemNasri Jan 27, 2025 •

edited

Loading

chibenwa Jan 27, 2025

HoussemNasri Jan 28, 2025

chibenwa Jan 29, 2025

HoussemNasri Jan 30, 2025

chibenwa commented Jan 24, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 28, 2025

chibenwa Jan 29, 2025

HoussemNasri Jan 29, 2025

chibenwa Jan 29, 2025

chibenwa Jan 29, 2025

Arsnael commented Feb 3, 2025

		.switchIfEmpty(Mono.fromRunnable(
		() -> LOGGER.trace("VEvent '{}' was not found in Calendar '{}'.", eventUid, calendarURI)))

Provide an API to interact with CalDav server #1465

Are you sure you want to change the base?

Provide an API to interact with CalDav server #1465

Conversation

HoussemNasri commented Jan 15, 2025 • edited Loading

TODO:

HoussemNasri commented Jan 22, 2025

Choose a reason for hiding this comment

HoussemNasri Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chibenwa commented Jan 24, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 27, 2025

chibenwa commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arsnael commented Feb 3, 2025

HoussemNasri commented Jan 15, 2025 •

edited

Loading

HoussemNasri Jan 27, 2025 •

edited

Loading