Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU] Auto-complete does not suggest LDAP mailing lists addresses #1480

Open
quantranhong1999 opened this issue Jan 20, 2025 · 3 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@quantranhong1999
Copy link
Member

Description of the bug

Given I am [email protected], auto-complete does not suggest LDAP mailing list [email protected] addresses and only suggests govmu.org addresses.

Reason: we are matching exactly the domain part https://github.com/linagora/tmail-backend/blob/master/tmail-backend/jmap/extensions-opensearch/src/main/java/com/linagora/tmail/james/jmap/OSEmailAddressContactSearchEngine.java#L182

Should we match the lists prefix too @chibenwa ?

(not reported so far by customers)

@quantranhong1999 quantranhong1999 added bug Something isn't working enhancement New feature or request labels Jan 20, 2025
@chibenwa
Copy link
Member

chibenwa commented Jan 20, 2025

Should we match the lists prefix too @chibenwa ?

It's more complicated than that.

We should only advertise the list through auto-complete if the user has the right to write to the mailing list.
So it needs to be populated on a per-user basis...

We wouldlikely need a detailed LSC script that:

  • adds open lists into domain ato-complete DB
  • adds list which the guy is member of into the user DB (|(&(businessCategory=memberRestrictedList)(member=<userDN>))(businessCategory=ownerRestrictedList)(owner=<userDN>))
    (member lists with this user and a member + ownerlist with this user as a member)

And then its more about adding the 2 tasks into LSC...

@quantranhong1999 you want to create this task?

Reason: we are matching exactly the domain part https://github.com/linagora/tmail-backend/blob/master/tmail-backend/jmap/extensions-opensearch/src/main/java/com/linagora/tmail/james/jmap/OSEmailAddressContactSearchEngine.java#L182

I think there's a mis-understanding. Here domain just denote "looks up in the DB of the domain for that specific user"

It do not says "the contact should be scoped by domain" BTW we have no such limits as far as I am aware of.

@quantranhong1999
Copy link
Member Author

Yes, indeed that would sound complicated.

adds list which the guy is member of into the user DB

We do not expose the user contact routes via webadmin (yet).

We wouldlikely need a detailed LSC script that

I am not sure the LSC is the right framework for the job. Maybe it "could" do the job but would be requiring tweaking around.

Initially, I thought quickly this could be a quick win. If this is complicated like this, maybe we should put this on hold until customers really ask for this side enhancement?

@chibenwa
Copy link
Member

maybe we should put this on hold until customers really ask for this side enhancement?

+1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants