Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the config file names #215

Open
ClementPernet opened this issue Oct 14, 2022 · 0 comments
Open

Revise the config file names #215

ClementPernet opened this issue Oct 14, 2022 · 0 comments

Comments

@ClementPernet
Copy link
Member

The naming convention and location in install-dir of the config header files are inconsistent between givaro fflas-ffpack and LinBox and not clear.
Currently:

  • in givaro:
    • install-dir/givaro-config.h contains the auto-generated config informations
    • install-dir/givaro/givconfig.h includes the above and adds more stuff. This is the file to be inlcluded by the user.
  • in fflas-ffpack
    - install-dir/fflas-ffpack/config.h contains the auto-generated config informations
    - install-dir/fflas-ffpack/config-blas.h contains the auto-generated config informations
    - install-dir/fflas-ffpack/fflas-ffpack-config.h includes the above and adds more stuff
  • linbox works similarly as fflas-ffpack.

Suggested change:

  1. rename the autogenerated config files to install-dir//config-detected.h (hence move givaro's file location)
  2. rename the main configuration file to install-dir//-config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants