Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push rejected with compilation error #27

Open
bkeepers opened this issue Jul 3, 2014 · 4 comments
Open

Push rejected with compilation error #27

bkeepers opened this issue Jul 3, 2014 · 4 comments

Comments

@bkeepers
Copy link

bkeepers commented Jul 3, 2014

I don't have time to investigate right now, but my deploys to heroku started failing this morning with:

-----> Building runtime environment
/tmp/buildpack_c475cde4-d577-4a04-a126-7e833f50343c/bin/compile: line 255: [: too many arguments

Full log: https://gist.github.com/bkeepers/83e90fa55fba0dc91f06

@searls
Copy link
Member

searls commented Jul 3, 2014

Do you recall which time?

On Wed, Jul 2, 2014 at 9:00 PM, Brandon Keepers [email protected]
wrote:

I don't have time to investigate right now, but my deploys to heroku started failing this morning with:

-----> Building runtime environment
/tmp/buildpack_c475cde4-d577-4a04-a126-7e833f50343c/bin/compile: line 255: [: too many arguments

Full log: https://gist.github.com/bkeepers/83e90fa55fba0dc91f06

Reply to this email directly or view it on GitHub:
#27

@searls
Copy link
Member

searls commented Jul 3, 2014

The only recent change was merging in @mdoel's PR #26

It'd be super helpful if you could set your build pack to a prior ref and see if it was introduced by the PR.

On Wed, Jul 2, 2014 at 9:00 PM, Brandon Keepers [email protected]
wrote:

I don't have time to investigate right now, but my deploys to heroku started failing this morning with:

-----> Building runtime environment
/tmp/buildpack_c475cde4-d577-4a04-a126-7e833f50343c/bin/compile: line 255: [: too many arguments

Full log: https://gist.github.com/bkeepers/83e90fa55fba0dc91f06

Reply to this email directly or view it on GitHub:
#27

@bkeepers
Copy link
Author

bkeepers commented Jul 6, 2014

No clue why it just started failing, but apparently it's because I have all the lineman deps listed as devDependencies:

Heroku only installs production dependencies by default (this must have just changed in the last week or two), but you can override that with:

$ heroku config:set npm_config_production=false

Would it make sense to do this by default in the lineman buildpack, since it calls npm prune --production in the compilation process?

@bkeepers bkeepers closed this as completed Jul 6, 2014
@searls
Copy link
Member

searls commented Jul 6, 2014

Reopen please. I think you're right. Since we call npm ourselves from a shell script I'm confused how Heroku could have broken us. Nevertheless we should be able to force npm to install Dev deps

On Sun, Jul 6, 2014 at 11:12 AM, Brandon Keepers [email protected]
wrote:

Closed #27.

Reply to this email directly or view it on GitHub:
#27 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants