Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #17

Open
rafinskipg opened this issue Jan 18, 2014 · 28 comments
Open

Redesign #17

rafinskipg opened this issue Jan 18, 2014 · 28 comments

Comments

@rafinskipg
Copy link

linemanjs

We are offering ourselves to do a redesign of the web page. (Free, of course) If you want. This is one proposal, we can talk if you want something different

@searls
Copy link
Member

searls commented Jan 18, 2014

So thank you for several things, not least of which showing the initiative to improve the design of the lineman docs, but also to follow-through on it.

I suppose my only concerns are:

  1. Do folks prefer this design? (I think I do) (cc'ing way too many cooks into this kitchen: @toddkaufman @DerekBriggs @jasonlong @bkeepers @theotherzach @jasonkarns @bostonaholic @andrewvida @itg)
  2. Whatever changes you make ought to be compatible with the structure of the testdouble/lineman-docs such that the content doesn't need to be reworked. I just redesigned the docs page once, so I can vouch for this being possible. Of course, it's important that it continue to be responsive and usable from mobile with code blocks.
  3. I wonder whether this poses as any branding problems for @testdouble. I should probably have feedback from @chrisbasecraft before you invest a bunch of time. Since Lineman is a "testdouble-sponsored" project and not only contributed-to by us, using our website's exact design layout smelled a bit off at the time, anyway.

@rafinskipg
Copy link
Author

Ok,

  1. We'll wait till you decide, also maybe my buddy (the guy who has made the design) want to propose new things, i will notify him that there's an open issue so he can contribute.
  2. Yes , we have this in mind. We are just going to change some html/css.
  3. Ok, we'll wait. We know that this is just a proposal and you have to consider all the things. Maybe we can come to a solution in which the @testdouble site has a new visual as well.

As mentioned, I'll go to communicate your thoughts to my friend, @rafael_dsgn (twitter)

@searls
Copy link
Member

searls commented Jan 18, 2014

Sounds good. If we see folks 👍'ing this design for the lineman site, then I'd propose you guys start work on a long-running pull request that we can watch and contribute to.

@fivetanley
Copy link

👍 although you may want to dull the vibrancy of the td logo in the corner, sticks out in a wierd way imo

@searls
Copy link
Member

searls commented Jan 18, 2014

@fivetanley agreed on the logo, I'm 99% sure that it'll violate td's brand book guidelines, which indicate the logo should only ever be white or black. (we have a brand book! We're all grown up!)

@jasonlong
Copy link

I think the idea has some potential, but if I'm being picky I've gotta say I'm not feeling the colors. Then again, the neon green on the current site isn't my fav either. I do dig the circular mascot badge though. 👍

I just happened to be derping around on Kuler this morning and this palette grabbed my eye.

screen shot 2014-01-18 at 10 05 01 am

Just for kicks, I tried these colors out and I kinda like it (note: the type is mostly what's live right now). I have no idea how horribly this violates td's branding guidelines and such, so definitely feel free to ignore me.

lineman-color-concept

@searls
Copy link
Member

searls commented Jan 18, 2014

Yeah, in fact love-it-or-hate-it, the intensity and specificity of "test double green" is pretty intentional, so I'm a bit worried about muddying that up with arbitrary other green colors. If we're not going to use that green I'd want blessing from our branding folks.

@jasonlong
Copy link

Yep, makes sense.

I'm not sure how you feel about dark backgrounds, but that might be another option that would allow you to use your bright green in a different way. I think that could be pretty slick, but I don't want to further the muddy the waters here.

@searls
Copy link
Member

searls commented Jan 18, 2014

I agree. I don't love dark backgrounds because I don't read them well and I tend to perceive them as overly intimidating and masculine, which coincidentally is a shortcoming of lots of developer/build tools in the first place. It's why I went with a cotton candy color scheme for my lineman talk

@rggGit
Copy link

rggGit commented Jan 20, 2014

Hi everyone!
First of all, thanks for the feedback :) I'm glad to help this team.

Has i told to @rafinskipg and @searls through Twitter, this screen is an quick and small test. If you have and brand book, i'll be glad to follow the rules in it, just let me know these rules :)

I love the @jasonlong color scheme, but i don't know if it violates your brand book's rules. Also, I have seen the @searls talk about Lineman and, if you want, i could use this color scheme too, but would be nice to know something about your brand book :)

@searls
Copy link
Member

searls commented Jan 20, 2014

Hey @rggGit & @rafinskipg -- could you send me an email at [email protected]? I'd like to send you the brand book and discuss some ideas.

@chrisbasecraft
Copy link

If Lineman is intended to be hand-in-hand with Test Double, it would be crazy to abandon the new TD brand we just rolled out. I'm all for improved UX, but the feel of the brand is very important.

@searls
Copy link
Member

searls commented Jan 20, 2014

Hey @chrisbasecraft -- I completely agree. I think that what this discussion has caused is a realization that—for my part—I never really asked myself whether Lineman and Test Double's branding should be so tightly linked. I wanted some tieback, but because of the nature of open source (that anyone outside Test Double can and should contribute, that we don't provide any warranty, etc.) it seems just as wise to let Lineman be its own thing that Test Double sponsors and supports.

And if that's the direction that we do go down, then its branding shouldn't mimic/approximate what we've done for test double so far, but instead be its own thing. I just gave the same advice by e-mail to the two folks suggesting a design for the docs site.

@theotherzach
Copy link
Member

I think it has already been said, but if the Lineman site doesn't use the Test Double branding then it should very clearly not use the Test Double branding. I love that people like the tool enough to tweak the design of the page and I have no desire to squelch that.

I also don't think there is anything wrong with using our brand for Lineman's site since Lineman really does reflect Test Double's workflows and values.

I think we've got a multiple choice with no wrong answers.

@searls
Copy link
Member

searls commented Jan 20, 2014

Yep, agreed. I think most people are amenable to those being the two appropriate paths and I'm also open to either of them.

:hug:

@rggGit
Copy link

rggGit commented Jan 30, 2014

Hi again!

My apologies for my delay, i had been busy with my own work and i didn't have time enough :P

After reading your brand's doc, we have choosen colours, fonts and a flat style for the Lineman's site. We have tried to keep it as simple as possible, focusing the design on readability becasuse we think that an user's guide like this one must be comfortable to use. Also, we are going to use an fixed menu on top because we think that is important to keep the TD's logo on the screen.

Feel free to give us your feedback :)

Regards!

Home
linemanjs-940-home

Content example
linemanjs-940-content

@Foxandxss
Copy link

I like it, I really like simple designs.

Buen trabajo Rafael 👍

@rggGit
Copy link

rggGit commented Jan 30, 2014

Thanks a lot! :)

@searls
Copy link
Member

searls commented Feb 2, 2014

Whelp @rggGit I have to say this looks really nice. Information flow is much better thought out than it is currently. Anyone else have thoughts?

@searls
Copy link
Member

searls commented Feb 4, 2014

@rggGit & @rafinskipg -- I've just added you as contributors to the linemanjs org. Feel free to push branches & PRs straight to linemanjs/lineman-docs

@rafinskipg
Copy link
Author

Great! Thanks. We'll start with it as soon as possible. Good morning :D
El 04/02/2014 06:30, "Justin Searls" [email protected] escribió:

@rggGit https://github.com/rggGit & @rafinskipghttps://github.com/rafinskipg-- I've just added you as contributors to the linemanjs org. Feel free to
push branches & PRs straight to linemanjs/lineman-docs

Reply to this email directly or view it on GitHubhttps://github.com//issues/17#issuecomment-34032035
.

@rafinskipg
Copy link
Author

I'm working on it on my fork, https://github.com/rafinskipg/lineman-docs/tree/redesign i will do a pull request by the end of this week; Greetings!

@jasonkarns
Copy link
Member

@rafinskipg Be sure to merge in latest master from upstream. wrapper.us has been updated to generate the navigation/table-of-contents dynamically.

@rafinskipg
Copy link
Author

Ok, no problemo

2014-02-11 20:29 GMT+01:00 Jason Karns [email protected]:

Be sure to merge in latest master from upstream. wrapper.us has been
updated to generate the navigation/table-of-contents dynamically.

Reply to this email directly or view it on GitHubhttps://github.com//issues/17#issuecomment-34795432
.

Atentamente:
Rafael Pedrola Gimeno
www.rvpg.me

@rafinskipg rafinskipg mentioned this issue Feb 14, 2014
@rafinskipg
Copy link
Author

I'm gonna comment on searl's issues. You can try it out here

1. I'd love for the twitter & github links to land cleanly above the fold

-> I think we solved it

2. We should definitely retinaify every image

-> Main / Big images are now svg, with more quality

3. This is exacerbated because of how the fold doesn't line up with every viewport, but as a user scrolls, the switch from "landing screen" to "doc site" is really jarring (no css transition or anything); additionally, if a user scrolls back up they don't get back to the landing page.

-> Added css transitions

This little lineman glyph doesn't do anything when you click it. Snap to top? Show landing page?

-> Now it opens the green header

Ooh, I really like how the bar disappears and fades back in when the user scrolls up. I think it perhaps should also fade in during any scroll and then disappear when the user has stopped scrolling for a bit. I don't want to risk folks losing the menu button.

-> Done

You can try it out here

@rafinskipg
Copy link
Author

Let us know if something needs more changes, and sorry again for the delay... -_-''

@searls
Copy link
Member

searls commented Mar 13, 2014

Cool guys! Thanks for continuing to work on it. I'm interested to see what others think too!

My strongest piece of feedback:

I really feel that it's confusing/jarring for most users when they scroll-down past something but the site doesn't let them scroll back up to return to what they were just at. Having the splash cover transition away without being able to go back to it by scrolling back up is too frustrating, I feel.

@Foxandxss
Copy link

I like it, I would put some hint that there is a hidden top bar there. Maybe a button on a corner to toggle it. I find hard to make it appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants