chore(app/spire): make spire compilation possible for non-linux targets #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
cratelyn
reviewed
Feb 20, 2025
linkerd/app/src/spire.rs
Outdated
| @@ -17,17 +17,27 @@ pub struct Config { | |||
|
|
|||
| // Connects to SPIRE workload API via Unix Domain Socket | |||
| pub struct Client { | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
can we use cfg_attr to only mark this type as dead_code for not(target_os = "linux")?
There was a problem hiding this comment.
makes sense, will address
cratelyn
reviewed
Feb 20, 2025
Signed-off-by: Zahari Dichev <[email protected]>
olix0r
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the fact that SPIRE uses Unix domain sockets prevents us from building
the proxy for non-unix targets. This PR adds special casing that allows us to build for
these targets but makes the spire client fail at runtime. Non-unix support for Spire shall
be introduced at a later stage.
Signed-off-by: Zahari Dichev [email protected]