Mpris Player position is being updated automatically

[TanR314]

Already reported ? *

• I have searched the existing open and closed issues.

Regression?

Yes

System Information

Traceback (most recent call last):
 File "/usr/bin/ignis", line 5, in <module>
   main()
   ~~~~^^
 File "/usr/lib/python3.13/site-packages/ignis/main.py", line 12, in main
   cli(prog_name="ignis")
   ~~~^^^^^^^^^^^^^^^^^^^
 File "/usr/lib/python3.13/site-packages/click/core.py", line 1157, in __call__
   return self.main(*args, **kwargs)
          ~~~~~~~~~^^^^^^^^^^^^^^^^^
 File "/usr/lib/python3.13/site-packages/click/core.py", line 1078, in main
   rv = self.invoke(ctx)
 File "/usr/lib/python3.13/site-packages/click/core.py", line 1688, in invoke
   return _process_result(sub_ctx.command.invoke(sub_ctx))
                          ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
 File "/usr/lib/python3.13/site-packages/click/core.py", line 1434, in invoke
   return ctx.invoke(self.callback, **ctx.params)
          ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 File "/usr/lib/python3.13/site-packages/click/core.py", line 783, in invoke
   return __callback(*args, **kwargs)
 File "/usr/lib/python3.13/site-packages/ignis/cli.py", line 146, in systeminfo
   print(get_systeminfo())
         ~~~~~~~~~~~~~~^^
 File "/usr/lib/python3.13/site-packages/ignis/cli.py", line 32, in get_systeminfo
   return f"""{get_version_message()}
               ~~~~~~~~~~~~~~~~~~~^^
 File "/usr/lib/python3.13/site-packages/ignis/cli.py", line 23, in get_version_message
   Branch: {Utils.get_ignis_branch()}
            ~~~~~~~~~~~~~~~~~~~~~~^^
 File "/usr/lib/python3.13/site-packages/ignis/utils/get_ignis_version.py", line 55, in get_ignis_branch
   from ignis.__commit__ import __branch__  # type: ignore
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 File "/usr/lib/python3.13/site-packages/ignis/__commit__.py", line 3
   __commit_msg__ = "fix(tray): add icon theme of item to search path (#120)

I don't know why is this happening

Description

Okay so I ran a code to print the position of mpris player, then I paused it.
However, position is still being updated and printed

( Sorry, I mistakenly issued this in your dotfiles repo first )

How to reproduce

I guess it should be reproduced if you try to print the position by binding it

Logs, images, videos, config files, CSS/SCSS files

No response

[lost-melody]

ignis systeminfo fails because __commit__.py was generated with incorrect string syntax. You need to fix it like this: __commit_msg__ = """ xxx """.

sorry I misunderstood it, so I folded my comments here.

MprisPlayer sync position by an infinite loop:

    @Utils.run_in_thread
    def __sync_position(self) -> None:
        while True:
            position = self.__player_proxy.Position
            if position:
                self._position = position // 1_000_000
                self.notify("position")
            time.sleep(1)

so you'll need to compare it with the earlier value before printing:

self._position = player.get_position()
def print_and_return(pos: int):
    if pos != self._position:
        self._position = pos
        print("position changed:", pos)
        return f"{pos}"
Widget.Label(label=player.bind("position", print_and_return))

and, yes, I agree that this should be done by the MprisPlayer.

[linkfrg]

ignis systeminfo fails because __commit__.py was generated with incorrect string syntax. You need to fix it like this: __commit_msg__ = """ xxx """.

Thanks for the tip! Fixed in 77b16d7

[linkfrg]

I can reproduce with firefox, but can't with spotify.

 @Utils.run_in_thread
    def __sync_position(self) -> None:
        while True:
            position = self.__player_proxy.Position
            print(position)  # here
            if position:
                self._position = position // 1_000_000
                self.notify("position")
            time.sleep(1)

If you try to print a position value directly from D-Bus, you will get the same problem (in case firefox).
The same if you try to get the position using D-Spy, firefox updates it by itself.
So, I have no idea how to fix this, this issue is on firefox side.

[TanR314]

Yeah, I am also getting this problem on Zen-browser only 😢

[linkfrg]

ignis systeminfo fails because __commit__.py was generated with incorrect string syntax. You need to fix it like this: __commit_msg__ = """ xxx """.

Thanks for the tip! Fixed in 77b16d7

finally fixed in a998164

[linkfrg]

I found a workaround for this in #160, could you test it?
However, on a fresh start of Ignis, the position will be wrong anyway, because firefox provides the wrong value.
#160 only makes MprisPlayer ignore updated position if the player is paused.