Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.url is not working on certain pages #10

Open
rnbguy opened this issue Aug 30, 2023 · 3 comments · Fixed by #11
Open

.url is not working on certain pages #10

rnbguy opened this issue Aug 30, 2023 · 3 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@rnbguy
Copy link

rnbguy commented Aug 30, 2023

It would be great if Page had a url() method to grab the current location of the page.

Puppeteer already has this.
@lino-levan
Copy link
Owner

Agreed.

@lino-levan lino-levan mentioned this issue Aug 31, 2023
Merged
@lino-levan
Copy link
Owner

Reopening because of issues with certain URLs

// doesn't work
"https://doi.org/10.1002/mds.25964",
"https://onlinelibrary.wiley.com/doi/pdf/10.1002/mds.25964",

@lino-levan lino-levan reopened this Sep 3, 2023
@lino-levan lino-levan changed the title url() of a Page .url is not working on certain pages Sep 4, 2023
@lino-levan lino-levan added the bug Something isn't working label Sep 4, 2023
@jaydenseric
Copy link

See also #123 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: url property to page lino-levan/astral
3 participants
@jaydenseric @rnbguy @lino-levan