Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in y_pos of players and ball #11

Open
dimitrisnikolaou10 opened this issue Jul 5, 2018 · 1 comment
Open

Bug in y_pos of players and ball #11

dimitrisnikolaou10 opened this issue Jul 5, 2018 · 1 comment

Comments

@dimitrisnikolaou10
Copy link

Hey Kanstantsin,

There is a small bug in the y position of the players and the ball in the animation compared to reality. What we see as the y_pos in the animation is in fact the reflection of the y_pos. You can compare any play you have with highlights on youtube and you will understand what I mean.

A very easy fix would be to adjust the Ball.py and Player.py files as follows:

self.y = ball[3] --> self.y = Constant.Y_MAX - ball[3]

and

self.y = player[3] --> self.y = Constant.Y_MAX - player[3]

obviously, you will need to import the Constant file in both Ball and Player.

Great work otherwise, thanks for posting!

@linouk23
Copy link
Owner

linouk23 commented Oct 7, 2018

@dimitrisnikolaou10 hi, nice catch! Feel free to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants