fix: disable proxy when connecting to pcsd local socket #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 6 6
Lines 479 479
=======================================
Hits 397 397
Misses 82 82 ☔ View full report in Codecov by Sentry. |
|
[citest] |
|
I don't get why all tests are suddenly failing with |
|
@spetrosi some problem with support for vault? The hacluster password comes from the vault file |
|
[citest] |
|
Should be fixed in linux-system-roles/tft-tests#70 |
richm
reviewed
Mar 4, 2025
| @@ -214,6 +214,8 @@ def call_api_raw( | |||
| """ | |||
| response, info = fetch_url( | |||
| module, | |||
| # never use a proxy when connecting to a local unix socket (RHEL-81918) | |||
| use_proxy=False, | |||
There was a problem hiding this comment.
ok - since this will only ever be a local unix socket (and not a TCP/IP socket), proxies should never be used.
richm
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement:
Do not use proxy when connecting to local pcsd via unix socket on managed nodes.
Reason:
When a proxy is defined, it disrupts communication towards the local pcsd unix socket. This makes the role fail.
Result:
Role works even if a proxy is defined.
Issue Tracker Tickets (Jira or BZ if any):
https://issues.redhat.com/browse/RHEL-81918