Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use runtime os edition #334

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

rb-union
Copy link
Contributor

Use runtime OS edition instead of compilation
OS edition.

Log: Us runtime OS edition
Bug: https://pms.uniontech.com/bug-view-294085.html

Use runtime OS edition instead of compilation
OS edition.

Log: Us runtime OS edition
Bug: https://pms.uniontech.com/bug-view-294085.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • openFile函数中,ret变量在if (osMajor >= kMinOsEdition)条件判断后没有重新初始化,可能会导致逻辑错误。
  • qWarningqDebug日志信息应该包含更多的上下文信息,以便于调试和问题追踪。
  • QProcessstartDetached方法在ret = myProcess->startDetached(program, arguments);行被多次调用,应该检查是否每次都需要创建新的QProcess实例。
  • DSysInfo::majorVersion().toInt()可能抛出异常,应该添加异常处理。
  • qInfo日志在if (CamApp->isPanelEnvironment())条件判断之前调用,可能不必要。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit f6e2550 into linuxdeepin:master Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants