Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable auto start by default #121

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: disable auto start by default #121

merged 2 commits into from
Sep 6, 2024

Conversation

myml
Copy link
Member

@myml myml commented Aug 8, 2024 •
edited
Loading

不再将深度之家的图标安装到autostart目录
不默认使用开机自启

Log:

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

TAG Bot

TAG: 1.6.0
EXISTED: no
DISTRIBUTION: unstable

@myml
Copy link
Member Author

myml commented Aug 8, 2024

/integrate

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1856
PrNumber: 1856
PrBranch: auto-integration-10295157003

@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Aug 8, 2024
Open
@Zeno-sole
Copy link

/topic desktop-20240808

@deepin-ci-robot
Copy link

Add topic: desktop-20240808 successed.

@Zeno-sole
Copy link

/integr-topic desktop-20240808

@deepin-ci-robot
Copy link

Alreadly latest topic integration with deepin-community/Repository-Integration#1857

Zeno-sole
Zeno-sole reviewed Aug 8, 2024
View reviewed changes
debian/deepin-home.prerm Outdated Show resolved Hide resolved
@myml myml force-pushed the autostart branch 3 times, most recently from 2bf13ff to 09f6715 Compare August 9, 2024 08:36
myml added 2 commits August 9, 2024 16:37
@myml
feat: disable auto start by default
23590ec 
不再将深度之家的图标安装到系统目录
不默认使用开机自启

Log:
@myml
chore: Release 1.6.0
22660b7 
发布1.6.0版本

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在debian/deepin-home.postinst脚本中，使用|| true可能会导致在没有可执行文件的情况下也返回成功，这可能会掩盖实际的问题。
  • CMakeLists.txt中注释掉了install(FILES "../deepin-home-daemon.desktop" DESTINATION ${CMAKE_INSTALL_SYSCONFDIR}/xdg/autostart RENAME deepin-home.desktop)这可能会影响深度 home 应用的默认启动行为。
  • maincomponentplugin/feedback/Submit.qml中定义了onSignalsGetSysInfoResp函数，但没有提供上下文来判断是否需要这样的重构。

是否建议立即修改:

  • 是

@Zeno-sole
Copy link

/integr-topic desktop-20240808

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1857

@Zeno-sole
Copy link

/approve

@myml myml requested a review from justforlxz August 19, 2024 09:48
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, myml, Zeno-sole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml merged commit 8cc0f1e into master Sep 6, 2024
29 checks passed
@deepin-bot deepin-bot bot mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeno-sole Zeno-sole Zeno-sole left review comments

@justforlxz justforlxz justforlxz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myml @Zeno-sole @deepin-ci-robot @justforlxz