-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically set and use $VERSION #13
Comments
Define "main application". There is no such concept in this tool. Git hashes are IMO not a version scheme. Old versions may show up above newer versions etc... |
The application which is referenced in the desktop file, and is executed when AppRun runs. If it can't be done automatically, then how can it be done by hand? E.g., the TruFont script, when running, uses |
Anything like that is out of scope of the plugin, as it's handled on a higher level. Just export VERSION=1.2.3
export PIP_REQUIREMENTS="myapp==$VERSION"
./linuxdeploy-x86_64.AppImage ... --plugin conda ... |
How can I know the git string before git has even started working? |
What "git string"? Why should git have anything to do with this? Who even wants git hashes as versioning scheme? |
My TruFont script currently produces |
I don't do any of this sort of versioning any more, for the reasons stated here. Either do proper versioning, or combine the commit hash with a date to ensure proper sorting, or anything. The pure git hash is annoying. I have no clue where git would be running in the process. If it's run by In general, it's not recommendable to install stuff from git directly (especially from dev branches), rather install stuff from PyPI etc. There is no way for a plugin like this to know "okay I'm installing the main app" or "I'm setting up a Python interpreter which will be used by another tool, e.g., for scripting". |
will have to do then. Is there a way to make
|
No, it'll use the latest version available. I am not sure how to request a specific tag this way. Please see https://pip.pypa.io/en/stable/reference/pip_install/#git. |
Not linuxdeploy-plugin-conda just linuxdeploy appimage here, why linuxdeploy will use git to get the hash id even thought I already set VERSION in app.desktop, if the version is not set in app.desktop, it use git I'm OK with it, if I provide VERSION, it should use the VERSION I set.
will use the VERSION, but this is just a workaround. |
First of all, it's not linuxdeploy, it's appimagetool that enforces this git hash stuff. The key in a desktop file is not |
iirc all that appimagetool enforces is that some |
Automatically set and use
$VERSION
.git rev-parse --short HEAD
The text was updated successfully, but these errors were encountered: