Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in surfaceConcentration.m #24

Open
SyPark324 opened this issue Feb 23, 2023 · 0 comments
Open

Typo in surfaceConcentration.m #24

SyPark324 opened this issue Feb 23, 2023 · 0 comments

Comments

@SyPark324
Copy link

SyPark324 commented Feb 23, 2023

Dear developers,

Hello, I found some errors in surfaceConcentration.m file.
For the calculation using three paramters model (line 37, 39), I think it should be corrected as
cs_star_p = cs_barrato(1:param.Np)+(param.Rp_p./(Dps_eff .* 35)) .* (-jflux(1:param.Np)) + 8 * param.Rp_p .* Q(1:param.Np);
cs_star_n = cs_barrato(param.Np+1 : end) + (param.Rp_n ./ (Dns_eff .* 35)) .* (-jflux(param.Np+1:end)) + 8 * param.Rp_p.* Q(param.Np+1:end);

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant