Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprintf function error #551

Open
lianhe opened this issue Aug 4, 2024 · 2 comments
Open

sprintf function error #551

lianhe opened this issue Aug 4, 2024 · 2 comments
Labels
bug

Comments

@lianhe
Copy link

lianhe commented Aug 4, 2024

Many PHP files have an extra comma in their sprintf function in 3.2.5.such as
config-operators-list.php line159 ,
mng-list-all.php line311...
@filippolauria
Copy link
Collaborator

Thank you for your feedback. If you want to push your fixes to this repository, it is actually quite simple. Have a look at the first contributions how to 😄

leewp14-inf added a commit to infonal-my/daloradius that referenced this issue Oct 18, 2024
@leewp14-inf
app/operators: remove extra comma from sprintf statement
a6613ea 
Fixes lirantal#551
Resolves the following php error:
"PHP Parse error: syntax error, unexpected ')' in ..."
@leewp14-inf
Copy link

@lianhe What's your php version?
Initially I was using PHP7.2 due to environment restriction, after upgraded to PHP7.4 there's no error anymore, no need to fix anything.
Also if you happen to use PHP7.2, you will get plenty of syntax error, which is resolved by simply upgrade to PHP7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lianhe @filippolauria @leewp14-inf