Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can I use this with page_cache? #8

Open
patroqueeet opened this issue Apr 4, 2016 · 6 comments
Open

can I use this with page_cache? #8

patroqueeet opened this issue Apr 4, 2016 · 6 comments

Comments

@patroqueeet
Copy link

if so, how?

@patroqueeet
Copy link
Author

no update?

@litchfield
Copy link
Owner

Not sure it would make sense to do that? If it's cached, it'll be coming straight from the cache.

@tingletech
Copy link

I think this question might be related to the issue I'm struggling with at the moment.

I have django per-site cache turned on. The middleware throws a pickle error unless I use the never_cache decorator.

Exception Type: PicklingError at /sitemap-static.xml
Exception Value: Can't pickle <type 'generator'>: attribute lookup __builtin__.generator failed

http://dpaste.com/0B8BFNM

I don't think I want "never_cache" b/c then cloud front won't cache the pages.

I guess I have to switch to per-view cache

tingletech added a commit to tingletech/public_interface that referenced this issue Jun 27, 2016
@litchfield
Copy link
Owner

Yes unfortunately streaming doesn't play well with caching- it doesn't really make sense anyway, except for the benefit of less memory usage?

If you're using a CDN, do you really need this?

@patroqueeet
Copy link
Author

at least for me it is desirable as rendering the pages on request took too much time and my nginx timed out. regenerate once a day and then cache for the many GoogleBot accesses seemed to be reasonable to me. for now I switched back to regular django sitemaps with caching and my SEO rank responded positively to that ...

@tingletech
Copy link

Maybe I don't need this (or maybe I don't understand what this does), but in my case I've got over 500,000 pages on my site which are backed by a sorl index. Somewhere else in my codebase, I have a generator that will page the solr results with cursorMark. Looking at django.contrib.sitemaps I can't see how that would be able to work for this -- and I don't want to have a special process to generate sitemaps if I can avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants