🦺[Tech debt] Remove the options to save the seed. Block user until they confirm the seed. #195
Labels
🦺 tech debt
Actions that help maintain the repo and application
Comments
3 tasks
kcw-grunt
added
🥳 feature
kcw-grunt
changed the title
kcw-grunt
added a commit
that referenced
this issue
Apr 2, 2024
* fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> * [Bugfix] Replace the LF Support View (#159) * Moved the LF Cell from Send. - BartyCrouch linted the stigns files. * Updated the LF Support location - Reset the localiaztion language to ‘Customer support’ - Add the dismissal actions * [Bugfix] Fix buy tab: Simplex urls (#157) * Updated the url to new servers * Linted the Localized strings * Setup url constants * updated pk file status * Updated per PR review comments * fixed naming of the url variable * [Merge v2.8.3] into Develop (#169) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Master (#153) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * version bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Feature Issue 154] Adding Unstoppable Domains functionality (#155) * Added UD to Podfile - Stubbed out the view, viewModel and the test class for UD * [UI Polish] Added images and localized strings - Added more of strings and UD structure - Trimmed images to resize for button - Added localized strings for placeholder * Updated UnstoppableDomainsView and Model details - Added DEV notes script - Adjusted Previews by unchecking the `build install only` * Added more tests - UnstoppableDomains View Model tests - SupportLitecoinFoundationViewModel tests * reformatted code in new SwiftUI views and viewModels * Added UD action to the SendViewController * Updated project * Updated localized UD Placeholder * Setup API keys * removed pk file * Changed the localizations related to UD - Added ‘Or’ label - Added UD placeholder text - Changed the LTC address placeholder text * Added in the Or and relayout of the button - Added Partner layout view for UD and Simplex * Resolved code review comments - Update the localizations - Refactored the UD shared instance (singleton) to retain throguh the call - Added timing probes * revert to current version * reformatted the Support LF view strings * Remove Test Playground. * Removed unused SocialView and ViewModel * Improved resolution - Added a Dispatch and ‘exit’ when address is found sooner than 12 secs. Much better experience for the user. * Added infura * Resolved review comments * Rewrote copy for “Enter a Litecoin address” * Fix some trivial conflict markers (#177) * [Bugfix] Upgrade the business logic for Unstoppable Domains (#179) * Fix some triival conflict markers * Added test to button once the UD string meets a minimum length * Clears address text field when Lookup button is pressed * Set the background color of the AlertToast * Locailization of the alert language * move logic to release the first responder * per review notes * [Feature] Litecoin card v1 (#180) * [Litecoin Card] Progress Step 1 - Major work: litecoin-card TabBarView refactor - Updated UIColor for Color - SwiftUI preview devices - Working out the Nav polish - Fixed hard-coded UD lookup label with proper localizations - Commented out BitId * [Litecoin Card] Progress Step 2 - Added more localizations - Rebuilding registration view need to add keyboard - Fixed the animation for the card view - Fixed Alert name collisions to the SimplexAlert * [Litecoin Card] Progress Step 3 - Added Login views and localizations - Added partnerAPI Swift Package - Layout the registration view - Add more localizations - BUGFIX: Image missing in this branch. * [Litecoin Card] Progress Step 4 More localizations Added data Validators Final Polish for Registration View Registration View Modal wiring works * [Litecoin Card] Progress Step 5 Register works to the model Login is working Added animation for Login/Logout Login and Loogut working Added localizations More localizations * [Litecoin Card] RC 1 polishes Communcations polishing + dev cleanup Polishing the RegistrationView layout Fixed bug: https://github.com/litecoin-foundation/loafwallet-ios/issues/175 * [Litecoin Card] RC2: removed defunct script * per review comments - Ar files removal - Cleanup localizable - Removed Ar.proj files - Removed empty class - Added all Validation localization framework - Added localizations of the validations - Refactored per review notes * Bugfix- login message Added failure message localizations * [Merge v3.0.0] into Develop (#184) * version bump * Added some tests * Refactored the login logic - Used the status of the binding to change the UI * Added combined logic of the email and password fields to enable login button Reference @losh11 comment: `The cards login now gives a good login failed alert. However I think the login button should be disabled until the text in the email input is validated as email format.` * build bump * [HOTFIX] hide litecoin card (#192) * [Merge v3.0.0] into Master (#183) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> * [Bugfix] Replace the LF Support View (#159) * Moved the LF Cell from Send. - BartyCrouch linted the stigns files. * Updated the LF Support location - Reset the localiaztion language to ‘Customer support’ - Add the dismissal actions * [Bugfix] Fix buy tab: Simplex urls (#157) * Updated the url to new servers * Linted the Localized strings * Setup url constants * updated pk file status * Updated per PR review comments * fixed naming of the url variable * [Merge v2.8.3] into Develop (#169) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Master (#153) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * version bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Feature Issue 154] Adding Unstoppable Domains functionality (#155) * Added UD to Podfile - Stubbed out the view, viewModel and the test class for UD * [UI Polish] Added images and localized strings - Added more of strings and UD structure - Trimmed images to resize for button - Added localized strings for placeholder * Updated UnstoppableDomainsView and Model details - Added DEV notes script - Adjusted Previews by unchecking the `build install only` * Added more tests - UnstoppableDomains View Model tests - SupportLitecoinFoundationViewModel tests * reformatted code in new SwiftUI views and viewModels * Added UD action to the SendViewController * Updated project * Updated localized UD Placeholder * Setup API keys * removed pk file * Changed the localizations related to UD - Added ‘Or’ label - Added UD placeholder text - Changed the LTC address placeholder text * Added in the Or and relayout of the button - Added Partner layout view for UD and Simplex * Resolved code review comments - Update the localizations - Refactored the UD shared instance (singleton) to retain throguh the call - Added timing probes * revert to current version * reformatted the Support LF view strings * Remove Test Playground. * Removed unused SocialView and ViewModel * Improved resolution - Added a Dispatch and ‘exit’ when address is found sooner than 12 secs. Much better experience for the user. * Added infura * Resolved review comments * Rewrote copy for “Enter a Litecoin address” * Fix some trivial conflict markers (#177) * [Bugfix] Upgrade the business logic for Unstoppable Domains (#179) * Fix some triival conflict markers * Added test to button once the UD string meets a minimum length * Clears address text field when Lookup button is pressed * Set the background color of the AlertToast * Locailization of the alert language * move logic to release the first responder * per review notes * [Feature] Litecoin card v1 (#180) * [Litecoin Card] Progress Step 1 - Major work: litecoin-card TabBarView refactor - Updated UIColor for Color - SwiftUI preview devices - Working out the Nav polish - Fixed hard-coded UD lookup label with proper localizations - Commented out BitId * [Litecoin Card] Progress Step 2 - Added more localizations - Rebuilding registration view need to add keyboard - Fixed the animation for the card view - Fixed Alert name collisions to the SimplexAlert * [Litecoin Card] Progress Step 3 - Added Login views and localizations - Added partnerAPI Swift Package - Layout the registration view - Add more localizations - BUGFIX: Image missing in this branch. * [Litecoin Card] Progress Step 4 More localizations Added data Validators Final Polish for Registration View Registration View Modal wiring works * [Litecoin Card] Progress Step 5 Register works to the model Login is working Added animation for Login/Logout Login and Loogut working Added localizations More localizations * [Litecoin Card] RC 1 polishes Communcations polishing + dev cleanup Polishing the RegistrationView layout Fixed bug: https://github.com/litecoin-foundation/loafwallet-ios/issues/175 * [Litecoin Card] RC2: removed defunct script * per review comments - Ar files removal - Cleanup localizable - Removed Ar.proj files - Removed empty class - Added all Validation localization framework - Added localizations of the validations - Refactored per review notes * Bugfix- login message Added failure message localizations * version bump * Added some tests * Refactored the login logic - Used the status of the binding to change the UI * Added combined logic of the email and password fields to enable login button Reference @losh11 comment: `The cards login now gives a good login failed alert. However I think the login button should be disabled until the text in the email input is validated as email format.` * build bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * Hide Card Tab * added comments for v1 Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Bugfix]UD resolved address / got callback (#193) * Fixed bug: resolved address / got callback - Added a dispatch group - Fixed the bug by adding wait to the group from (@JohnnyJumper) - Refactored partner plist * removed cruft * polish UD model * v3.0.1 Card Hidden - found hidden code… * Resolved review comment - polished the address send label * removed unused code - clean comments * [Merge into Develop] Release v3.1.1 (#195) * [Merge v3.0.0] into Master (#183) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: