Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: json_serializer and json_deserializer are not being set on the db connection #9

Open
4 tasks
guacs opened this issue Nov 15, 2023 · 0 comments
Open
4 tasks

Bug: json_serializer and json_deserializer are not being set on the db connection #9

guacs opened this issue Nov 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@guacs
Copy link
Member

guacs commented Nov 15, 2023

Description

The json_serializer and json_deserializer are not being set on the database connection. This must be done on each connection as shown here using the init when creating pools.

Also, I propose allowing the two values to be set as None in which case the JSON serialization/deserialization is not set on the connections at all. This would be helpful for cases where the user does not need JSON serialization/deserialization or if they are setting it up in the init method provided to the PoolConfig.

URL to code causing the issue

No response

MCVE

No response

Steps to reproduce

No response

Screenshots

No response

Logs

No response

Litestar Version

...

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)
@guacs guacs added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guacs