Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

netlink-proto: refactor #141

Open
little-dude opened this issue Jan 17, 2021 · 1 comment
Open

netlink-proto: refactor #141

little-dude opened this issue Jan 17, 2021 · 1 comment
Assignees

Comments

@little-dude
Copy link
Owner

This is just a couple notes to myself regarding some netlink-proto simplifications I've been contemplating for a while:

  • have a distinct codec for the audit protocol, instead of using feature flags
  • don't use the tokio codec trait? They force us to copy the data in intermediate buffers, which most of the time we don't need (unless we read multiple datagrams at once, like with the audit protocol).
  • have NetlinkFramed return a Result instead of an Option
  • rename NetlinkFramed into Transport maybe?
  • don't use unbounded channels? But then we have to handle errors when they get full. Not sure how to do that

Also:

@little-dude
Copy link
Owner Author

Also noticed that we need to upgrade to newer tokio-utils and bytes versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant