You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
This is a good idea in theory, but in practice this is a breaking change which will force users to update their code for no gain in terms of features or bug fixing. For the record:
ethtool seems to use the singular version consistently. Changing all the type names may be a bit annoying for users, but we could probably do that incrementally: change the names, but keep aliases with a deprecation warning. netlink-generic-packet uses Attrs except for OppolicyIndexAttr. I think we could just change this one. netlink-packet-wireguard uses the plural version consistently.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looking through the codebase I see a couple examples of enums where some are plural (
FooAttrs
) and some aren't (FooAttr
):rg 'enum .*Attr'
Might be good to settle on one in future breaking change updates (it looks like most projects choose the plural version).
The text was updated successfully, but these errors were encountered: