Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Secrets for sensitive data inside GoogleBigQuery connection config #49

Open
hugobarauna opened this issue Oct 18, 2022 · 2 comments

Comments

@hugobarauna
Copy link
Member

When we drag and drop the JSON credentials file to the Google BigQuery connection config, the Smart Cell generates code that contains sensitive data, like the private_key and private_key_id.

Now that we have the Secrets feature, we could use that feature somehow instead of saving sensitive data inside the notebook.

What do you think?

@aleDsz
Copy link
Member

aleDsz commented Oct 19, 2022

I've been thinking about this and storing the JSON itself inside a secret could work (detecting that's a JSON, and decoding after the System.fetch_env!/1). @josevalim WDYT?

@josevalim
Copy link
Contributor

josevalim commented Oct 19, 2022

We would have to support secret uploads in the secret modal. Perhaps via a configuration parameter set when the modal is open by Kino. Then the file is uploaded and its contents stored in the env var.

/cc @cristineguadelupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants