Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodeSelector to Helm chart #130

Open
mogopz opened this issue Apr 14, 2021 · 4 comments · May be fixed by #637
Open

Add nodeSelector to Helm chart #130

mogopz opened this issue Apr 14, 2021 · 4 comments · May be fixed by #637
Labels
enhancement New feature or request

Comments

@mogopz
Copy link

mogopz commented Apr 14, 2021

Hi,
I was going to make a PR to add this myself but this repo doesn't seem to actually contain the Helm repo source (I'm looking at https://assets.logdna.com/charts). If the Helm code is public and you can point me to the right location I'm happy to raise a PR for this.

It would be useful to have a nodeSelector added to the DaemonSet manifest. At the moment your official LogDNA Docker images don't support ARM and since we run a cluster with a mixture of amd64/arm64 instances we need a way to specify which nodes to run on.
@jorgebay
Copy link
Contributor

Hi @mogggggg !
The repo that generates the helm charts is currently private. It's currently just a port of the original helm chart at the deprecated "stable" repo.

There's an internal follow-up ticket for revamping the Helm charts to include stuff like the ability to set the securityContext.

Adding a nodeSelector makes sense, I've include it in our internal ticket.

Let's keep this issue open and we'll post any update here.

@jorgebay jorgebay added the enhancement New feature or request label Jun 14, 2021
@mogopz
Copy link
Author

mogopz commented Feb 9, 2022

Has there been any progress on this?

@mogopz mogopz mentioned this issue Aug 24, 2022
Open
@mohitthakur3
Copy link

Hey Team,

I am also struggling to add ¸ parameter, and this very important. In our Kubernetes cluster we have some nodes with Taint, and our requirement is just to install the agent on the nodes that is having taint. But right now it deploy the agent on those nodes as well which is not having any taint or tolerations. To fix this problem we need to add nodeSelector with tolerations. So as I see logdna chart not having parameter we can set this.

Please fix this issue ASAP.

@logdnabot

Thanks.

@echoblag
Copy link

echoblag commented Oct 1, 2024 •
edited
Loading

Hi there,
I appreciate this issue has been open for a while.

Has there been any progress on adding a nodeSelector option to the Helm chart?

This is a common setting that would be extremely useful at this point.

mdeltito added a commit that referenced this issue Dec 5, 2024
@mdeltito
docs(helm): document additional templated chart values
aa4bee2 
Adds the following templated values from the latest verion of the chart:

- `podSecurityContext`
- `nodeSelector`
- `podAnnotations`
- `secretAnnotations`

Fixes #130
@mdeltito mdeltito linked a pull request Dec 5, 2024 that will close this issue
Open
mdeltito added a commit that referenced this issue Dec 5, 2024
@mdeltito
docs(helm): document additional templated chart values
868f7da 
Adds the following templated values from the latest verion of the chart:

- `podSecurityContext`
- `nodeSelector`
- `podAnnotations`
- `secretAnnotations`

Fixes #130
mdeltito added a commit that referenced this issue Dec 7, 2024
@mdeltito
docs(helm): document additional templated chart values
bb9eef4 
Adds the following templated values from the latest verion of the chart:

- `podSecurityContext`
- `nodeSelector`
- `podAnnotations`
- `secretAnnotations`

Fixes #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(helm): document additional templated chart values logdna/logdna-agent-v2
4 participants
@jorgebay @mogopz @echoblag @mohitthakur3