Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing eigen3 includes #99

Open
josch opened this issue Mar 21, 2019 · 1 comment
Open

missing eigen3 includes #99

josch opened this issue Mar 21, 2019 · 1 comment

Comments

@josch
Copy link

josch commented Mar 21, 2019

Hi,

since ply_c requires eigen3, this requirement should be stated in the CMakeLists.txt without it, the compilation will not be able to add the eigen3 include directories. Here is a patch that worked for me:

diff --git a/partition/ply_c/CMakeLists.txt b/partition/ply_c/CMakeLists.txt
index 169c98f..eaedb5a 100644
--- a/partition/ply_c/CMakeLists.txt
+++ b/partition/ply_c/CMakeLists.txt
@@ -13,8 +13,9 @@ SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11 -fopenmp -O3")
 ##############################
 
 find_package(Boost 1.65.1 COMPONENTS python numpy REQUIRED)
+find_package(Eigen3 REQUIRED)
 
-include_directories(${Boost_INCLUDE_DIRS})
+include_directories(${Boost_INCLUDE_DIRS} ${EIGEN3_INCLUDE_DIRS})
 link_directories(${Boost_LIBRARY_DIRS})
 
 message("Boost includes ARE " ${Boost_INCLUDE_DIRS})
@loicland
Copy link
Owner

loicland commented Apr 4, 2019

Thanks, that's useful. Adding it to the pile for the 0.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants