fix: leading or trailing spaces in Longhorn UI break search

[houhoucoop]

What this PR does / why we need it

Trim the input value before submitting

Issue

[BUG] Leading or trailing spaces in Longhorn UI break search #10491

Test Result

• Navigate to the Volume page
• Enter a volume name with leading or trailing spaces in the search box
• Ensure the search works correctly
• Repeat the same steps in the Node search box

Additional documentation or context

N/A

Summary by CodeRabbit

• Bug Fixes
  • Refined search input handling so that any extra whitespace is automatically removed before executing a search. Users will now experience more consistent and accurate search results as the input value is cleaned up prior to processing.

[coderabbitai]

Walkthrough

The pull request modifies the handleSubmit method within the Filter component. It now trims the value in the component’s state by updating it via setState before invoking the onSearch callback. The updated control flow introduces an intermediate state update step, ensuring that only the trimmed value is passed when executing the search operation.

Changes

File(s)	Change Summary
src/components/Filter/Filter.js	Modified the handleSubmit method to trim the value in state using setState and then, in the callback, call onSearch with the updated state.

Sequence Diagram(s)

sequenceDiagram
    participant F as Filter Component
    participant S as State
    participant C as onSearch Callback
    F->>S: setState(trimmed value)
    S-->>F: State updated
    F->>C: onSearch(updated state)

Loading

Suggested labels

require backport v1.8

Suggested reviewers

• c3y1huang
• a110605
• derekbit

Poem

I'm a coding bunny hop,
Trimming values 'til they pop.
With state refreshed and neat array,
OnSearch gets a cleaner display.
A hop and a skip, code refined in play!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca97fc and 0210306.

📒 Files selected for processing (1)

• src/components/Filter/Filter.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (1)

src/components/Filter/Filter.js (1)

42-45: Great implementation of the trim functionality!

This change correctly fixes the issue with leading or trailing spaces breaking search functionality. Using setState with a callback ensures that the search is performed with the trimmed value, which effectively addresses the PR objective.

The implementation follows React best practices:

• Functional form of setState to update based on previous state
• Callback to execute search only after state is updated
• Modern spread operator to create a new state object

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.