Link inside markers description send and invalid JSON error on approval

[lpdumas]

Should we allow links inside the descriptions of a marker?

[jsilvestre]

What is the error message exactly ?

I'm asking because the Validator does not check the translation_data parts so a link inside the marker description should pass the validation.

Give me all the details you have!
Thanks.

[lpdumas]

Paste this in a marker description, and try to send the map for approval. Test

The error message i get:
Ooops
The JSON is invalid: . This can be a bug,do not hesitate to let us know !

On 2012-07-31, at 1:48 PM, Joseph Silvestre wrote:

What is the error message exactly ?

I'm asking because the Validator does not check the translation_data parts so a link inside the marker description should pass the validation.

Give me all the details you have!
Thanks.

---

Reply to this email directly or view it on GitHub:
#24 (comment)

[jsilvestre]

Ok I think I know what happened: a link uses <"> for the html tag. JSON too...so during the decoding, PHP does not understand what is given to him and says "json not well formed".

Solution ?

• adding a backslash in front of the <"> inside the title and desc fields before the submission (client-side).
• doing the same thing but server-side, before the validation.
  It's just a regular expression so client side or server side...

Actually I am surprised that the JSON.stringify javascript function does not do it automatically (maybe there is a parameter for that ?)

edit: https://developer.mozilla.org/En/Using_native_JSON parameter "replacer" should do the trick ! If we go client-side and I think that's what we should do.

[jsilvestre]

Have you done anything about it ?

[lpdumas]

Not yet ;)
On Aug 8, 2012 7:46 PM, "Joseph Silvestre" [email protected] wrote:

Have you done anything about it ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-7601260.