-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the depth > 3, variable (invariant and coors_out) will be NaN #2
Comments
@JunDecNo indeed it does i threw in an extra norm in a place that makes sense (aggregated inner product across the higher order degrees, before projected into the update), and stabilized it do you want to perhaps send the author of this paper an email and see if he/she is missing normalization in the hierarchical tensor refinement module? |
@lucidrains Have you looked at the code for this repository ? Everything seems to work fine when I use it. |
@anine09 oh nice, the code was released after all! why did I bother 🤔🤣 |
I'll reconcile the differences later this week and wrap up the project |
@lucidrains After you answered my question about |
@anine09 lol oh no, ok |
I give an explanation. High-degree steerable features can be understood as electron clouds. The inner product describes the direct phase relationship between two electron clouds. The meaning of the modulus component is relatively weak, so the modulus component can be completely separated. In addition, Nan may be due to multi-channel reasons. This has been corrected by using the Frobenius norm in GMN[1]. In addition, in section 3.4 of EquiformerV2[2], there is a similar correction method in the HEGNN[3] code (https://github.com/GLAD-RUC/HEGNN/blob/main/models/HEGNN.py#L94). However, the method of directly correcting high-degree steerable features used in the GotenNet implementation mentioned by anine09 is also very interesting. Finally, I also recommend our HEGNN project (https://github.com/GLAD-RUC/HEGNN). You can consider using e3nn.o3.FullyConnectedTensorProduct to implement multi-channel high-degree steerable features (e.g. Eqs. (10)-(11) in the current version of GotenNet paper). [1] Equivariant Graph Mechanics Networks with Constraints |
I encountered this issue when using the example and setting the depth to 4.
The text was updated successfully, but these errors were encountered: