From 687fe0454eabb7de58c2810d149bfd48e44dbd72 Mon Sep 17 00:00:00 2001
From: Jakub Stasiak <jakub@stasiak.at>
Date: Thu, 22 Aug 2024 13:46:40 +0200
Subject: [PATCH 1/2] Enaboe all typescript-eslint recommended-type-checked
 rules

There's a bunch of good rules there and we already follow almost all of
them.

Making the backend code compatible with these rules uncovered some
potential issues in our code already.
---
 index.js | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/index.js b/index.js
index 367e157..7ab5bbe 100644
--- a/index.js
+++ b/index.js
@@ -3,7 +3,12 @@ module.exports = {
         browser: true,
         es2021: true,
     },
-    extends: ['standard', 'prettier', 'eslint:recommended'],
+    extends: [
+        'standard',
+        'prettier',
+        'eslint:recommended',
+        'plugin:@typescript-eslint/recommended-type-checked',
+    ],
     parser: '@typescript-eslint/parser',
     parserOptions: {
         ecmaVersion: 12,
@@ -44,5 +49,35 @@ module.exports = {
         // dependency (which I'd like to do ASAP, it pulls eslint-plugin-import and so many
         // transitive dependencies that we don't even use.
         'no-void': 'off',
+
+        /*
+        @typescript-eslint/recommended-type-checked exceptions
+
+        To be determined if we want to keep these rules disabled long-term, at least some
+        of these look useful, we just need to configure them so they don't generate so many
+        false positives.
+        */
+
+        '@typescript-eslint/require-await': 'off',
+        '@typescript-eslint/unbound-method': 'off',
+
+        // Being able to use and interact with "any" values
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-unsafe-member-access': 'off',
+        '@typescript-eslint/no-unsafe-assignment': 'off',
+        '@typescript-eslint/no-unsafe-return': 'off',
+        '@typescript-eslint/no-unsafe-call': 'off',
+        '@typescript-eslint/no-unsafe-argument': 'off',
+
+        // Generates a lof of false positives when it doesn't always understand when a value
+        // can be safely used in a string context. We can try to configure this behavior.
+        '@typescript-eslint/no-base-to-string': 'off',
+
+        // Prevents using Big (among others) in string templates
+        '@typescript-eslint/restrict-template-expressions': 'off',
+
+        /*
+        End of @typescript-eslint/recommended-type-checked exceptions
+        */
     },
 }

From ce764d5d1ad3cd656f71cd9d5133730f50c99921 Mon Sep 17 00:00:00 2001
From: Jakub Stasiak <jakub@stasiak.at>
Date: Thu, 22 Aug 2024 14:21:32 +0200
Subject: [PATCH 2/2] Update index.js

---
 index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.js b/index.js
index 31c2ca6..257af8b 100644
--- a/index.js
+++ b/index.js
@@ -7,7 +7,7 @@ module.exports = {
         'standard',
         'prettier',
         'eslint:recommended',
-        'plugin:promise/recommended'
+        'plugin:promise/recommended',
         'plugin:@typescript-eslint/recommended-type-checked',
     ],
     parser: '@typescript-eslint/parser',