Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating initial release #155

Closed
dhruvbalwada opened this issue Jun 17, 2024 · 5 comments
Closed

Creating initial release #155

dhruvbalwada opened this issue Jun 17, 2024 · 5 comments

Comments

@dhruvbalwada
Copy link
Collaborator

@IamShubhamGupto do you know how to solve the first remark that the reviewer made here about creating an initial release?

@dhruvbalwada
Copy link
Collaborator Author

In this process can we also delete the branches that have been merged (except the ones we are actively using to address reviewer comments), so that there is a fresh start.

@IamShubhamGupto
Copy link
Member

Hey @dhruvbalwada, Ive merged the previous PR as I think it address the concerns of the review. For creating a release, Ive started a draft release here. I hope youre able to see it. If not, let me know if you have any preference for the release title and description. Ive provided very basic entries for now.

You can either edit the draft or share the contents with me and I'll publish the release.

@dhruvbalwada
Copy link
Collaborator Author

I think the title and description seem good to me. Do we need to do anything else before we publish?
Now that the README has also been ingested, maybe it makes sense to publish?
If we make some changes to read me in response to the reviews, will they automatically appear in the release?

@IamShubhamGupto
Copy link
Member

I think the title and description seem good to me. Do we need to do anything else before we publish? Now that the README has also been ingested, maybe it makes sense to publish? If we make some changes to read me in response to the reviews, will they automatically appear in the release?

unfortunately, we would have to manually re release a newer version say v1.1 to incorporate further changes by the reviewers. Ill create a release now and if further changes are required, we can always bump up the version number

@dhruvbalwada
Copy link
Collaborator Author

Sounds good to me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants