Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOF example #146

Open
smebberson opened this issue Jan 31, 2025 · 5 comments
Open

TOF example #146

smebberson opened this issue Jan 31, 2025 · 5 comments

Comments

@smebberson
Copy link

The TOF unit information page references the following example from the M5Stack library. However, this library is now outdated and as you know, doesn't work with ESP32-S3 based M5Stack controllers.

Is it possible to include a working TOF example in this repository that would work with both ESP32, ESP32-Pico and ESP32-S3/ESP32-C* boards?

@lovyan03
Copy link
Collaborator

Hello, @smebberson
We need to be very careful about including sample code for specific optional products in this repository.
If we start doing that, we will have to include all products here, so we think it is best to basically do this for libraries for each unit.

We are currently working on a separate project called M5UnitUnified to unify the unit libraries.
This will likely be where we provide and support the new libraries.

@smebberson
Copy link
Author

@lovyan03, thanks for getting back to me. That makes a lot of sense :)

I've just discovered https://github.com/m5stack/M5Unit-TOF, which seems to use M5UnitUnified.

It looks as though this example code using UnitUnified, could be adapted to recreate https://github.com/m5stack/M5Stack/blob/master/examples/Unit/ToF_VL53L0X/ToF_VL53L0X.ino and should work with ESP32-S3 based devices due to using M5Unified?

@lovyan03
Copy link
Collaborator

Yes, that's it.

It should probably work with ESP32S3 and C3 as well.

@GOB52
Copy link
Contributor

GOB52 commented Jan 31, 2025

@smebberson

Hi, I am the author of the M5UnitUnified.

Cores and Units We are in progress for most combinations.
Also, the unit side libraries are newly written, not external ones.

Already CoreS3, AtomS3, NanoC6... + ToF/ToF4M combinations are working.

If you have any questions, problems, or corrections, we would be happy to receive an Issue/PR in the repository concerned.

@smebberson
Copy link
Author

Hi @lovyan03 and @GOB52, I've made an example that you might like to consider at m5stack/M5Unit-TOF#1.

I was thinking it could be linked on the TOF documentation page so that S3 based devices users wouldn't attempt to load the existing example and be disappointed to find it doesn't work on their device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants