Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset's dictionary not updated if one changes the collection dynamically #58

Open
Alvant opened this issue May 12, 2020 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Alvant
Copy link
Collaborator

Alvant commented May 12, 2020

  • Create a dataset
  • Call dataset.get_dictionary()
  • Change dataset's _data by renaming one of modalities (eg. lemmatized -> new_lemmatized)
  • Try to build a topic model using the dataset

Result: old modality in model's Phi
Expected: new modality in Phi

P.S.
One should also check that dataset._modalities is up-to-date

@Alvant Alvant added the bug Something isn't working label May 12, 2020
@Evgeny-Egorov-Projects
Copy link
Contributor

See? Exactly - if you change the _ variables or methods we don't guarantee proper functionality. You should know what you are doing when using those

@Alvant
Copy link
Collaborator Author

Alvant commented May 25, 2020

Well... yees... Ok. Then it should be clearly stated in the docstring that currently Dataset provides no way to modify the contents of a text collection (changing document/renaming document/adding modality/...). If you want to change something — use text editors, pandas, csv or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants