Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some spanish mnemonics are invalids when they should be valid #11

Closed
mrbianchi opened this issue Feb 13, 2020 · 2 comments
Closed

Some spanish mnemonics are invalids when they should be valid #11

mrbianchi opened this issue Feb 13, 2020 · 2 comments

Comments

@mrbianchi
Copy link

No description provided.

@wigy-opensource-developer
Copy link

wigy-opensource-developer commented Feb 17, 2020

@mrbianchi provided a test vector for this issue upstream.

Mnemonic: "camello pomelo toque oponer urgente lástima merengue cutis tirón pudor pomo barco"
Expected seed: 062c9762ba2032ea10618f4c7c86dafd4f11aaaebf83690f9d81c89de897ecc21fef228ba44d5288de2386cffaeb1443ec528b4e838554b7cde4eedb0ce90f91

I confirmed the seed on https://iancoleman.io/bip39/#spanish and found that the InvalidWord exception is caused by the mnemonic not being normalized to NFKD. The Spanish wordlist is properly normalized, so only the input needs to be as another existing upstream issue describes.

@maciejhirsz I have sent you #12 using https://github.com/unicode-rs/unicode-normalization#unicode-normalization

@maciejhirsz
Copy link
Owner

Thanks for the PR @wigy-opensource-developer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants