-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAMBO with a single final particle? (Do we need sampling in a 2->1 process?) #358
Comments
The code now builds but indeed the ME is always the same (which is OK), but the weight is negative (which is not ok!)
|
…build warning remains (madgraph5#358)
Ok thanks to @oliviermattelaer it is now clarified that it is normal that 2>1 processes are special. The point of gg>h was to check the EFT model. This is now indeed working (PR #352 after fixing #351 and related issues). I think that this specific RAMBO question for 2>1 can be closed. |
…adgraph5#358): NB random numbers are ignored
…2->1 rambo (madgraph5#358) (NB the heft_gg_h test now succeeds)
…dgraph5#358) - tested ok on heft_gg_h
In the end I added a simple patch and a warning in PR #365. At least now the final momenta should be correct (previously they were NaN). A warning is written out that the random numbers are ignored. |
…n merged in bbtt
…etter fix for rambo nparf==1 (madgraph5#358)
I am merging a better fix in PR #366 |
…for rambo 2 to 1 processes ccache /cvmfs/sft.cern.ch/lcg/releases/clang/12.0.0-8916b/x86_64-centos7/bin/clang++ -O3 -std=c++17 -I. -I../../src -I../../../../../tools -DUSE_NVTX -Wall -Wshadow -Wextra -ffast-math -march=haswell -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_HARDCODE_PARAM -I/usr/local/cuda-11.6/include/ -fPIC -c fsampler.cc -o fsampler.o In file included from RamboSamplingKernels.cc:8: ../../src/rambo.h:107:5: warning: array index 1 is past the end of the array (which contains 1 element) [-Warray-bounds] z[1] = po2log; ^ ~ ../../src/rambo.h:106:5: note: array 'z' declared here fptype z[nparf]; ^ 1 warning generated. ccache /cvmfs/sft.cern.ch/lcg/releases/clang/12.0.0-8916b/x86_64-centos7/bin/clang++ -O3 -std=c++17 -I. -I../../src -I../../../../../tools -DUSE_NVTX -Wall -Wshadow -Wextra -ffast-math -march=haswell -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_HARDCODE_PARAM -I/usr/local/cuda-11.6/include/ -fPIC -c fbridge.cc -o fbridge.o ../../src/rambo.h:107:2: warning: array index 1 is past the end of the array (which contains 1 element) [-Warray-bounds] (z[1]) = po2log; ^ ~ ../../src/rambo.h:106:1: note: array 'z' declared here mgOnGpu::fptype z[mgOnGpu::nparf]; ^ 1 warning generated.
…adgraph5/madgraph4gpu#358): NB random numbers are ignored
…dgraph5/madgraph4gpu#358) - tested ok on heft_gg_h
…that had been merged in bbtt
Hi @oliviermattelaer , next physics question :-)
For the EFT gg>h process of #344: after fixing other generation/build issues I am now getting this warning
I looked at the code, and indeed z[0] is never initialized. Initially I was concerned this might be a bug in the translation from Fortran to C indexes, and maybe that I had introduced this in changing the interfaces. But I realised that
Eventually, I realised that: maybe we do not need RAMBO (or any other phase space sampling) at all, if we have a 2->1 process?
Rephrasing this: with a 2->1 process do we not always have exactly the same matrix element with exactly the same momenta?
For the specific case of #344, I can see various options
More generally:
Thanks
Andrea
The text was updated successfully, but these errors were encountered: