Adding WebUtlity.HtmlDecode to get rid of valid HTML but invalid XML in filenames #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escapes when uploading images with escaped filenames(ä in my test case).
|
Actually, reading the tag into a XML document just to grab 2 attributes isn't the most efficient, but rolling your own actually good html tag parser isn't really an option either and I'd rather not add more dependencies(to for example HtmlAgilityPack) since I know how Mads feels about unnecessary dependencies. Parsing newly added files isn't something that really comes up that often so it shouldn't be a problem. |
|
Since nothing appears to be happening with this PR, I'm closing it to remove it from the open list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WebUtlity.HtmlDecode to get rid of valid HTML but invalid XML escapes when uploading images with escaped filenames(ä in my test case). Should fix #48.