Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AS6706T is confirmed #12

Closed
LPJon opened this issue Jan 1, 2024 · 6 comments
Closed

Support for AS6706T is confirmed #12

LPJon opened this issue Jan 1, 2024 · 6 comments

Comments

@LPJon
Copy link

LPJon commented Jan 1, 2024

Just letting you know support for the AS6706T platform is confirmed. Your assumptions about the GPIO pins for disks 5 and 6 are also correct. (As suggested in your asustor.c file.)

DanielGibson added a commit to DanielGibson/asustor-platform-driver that referenced this issue Feb 28, 2024
@DanielGibson
Copy link
Contributor

Thanks for confirming my assumptions about the SATA 5 and 6 LEDs!
I made the corresponding changes in #16, can you test them? :)

@LPJon
Copy link
Author

LPJon commented Feb 28, 2024

@DanielGibson I can confirm that your code lines up with what I have. I made some tweeks to use the red LED's for activity and green for power.

LED CONFIG SETTINGS:

        {
                .name            = "sata5:green:disk", // 17
                .default_state   = LEDS_GPIO_DEFSTATE_ON,
                //.default_trigger = "disk-activity",
        },
        { .name         = "sata5:red:disk",
                .default_state = LEDS_GPIO_DEFSTATE_ON, // 18
                .default_trigger = "disk-activity"},
        {
                .name            = "sata6:green:disk", // 19
                .default_state   = LEDS_GPIO_DEFSTATE_ON,
                //.default_trigger = "disk-activity",
        },
        { .name         = "sata6:red:disk",
                .default_state = LEDS_GPIO_DEFSTATE_ON, // 20
                .default_trigger = "disk-activity"},
};

GPIO DRIVER:

                GPIO_LOOKUP_IDX(GPIO_IT87, 61, NULL, 17, GPIO_ACTIVE_HIGH),     // sata5:green:disk
                GPIO_LOOKUP_IDX(GPIO_IT87, 62, NULL, 18, GPIO_ACTIVE_LOW),      // sata5:red:disk
                GPIO_LOOKUP_IDX(GPIO_IT87, 58, NULL, 19, GPIO_ACTIVE_HIGH),     // sata6:green:disk
                GPIO_LOOKUP_IDX(GPIO_IT87, 60, NULL, 20, GPIO_ACTIVE_LOW),      // sata6:red:disk

@DanielGibson
Copy link
Contributor

Did you also make those changes for SATA1-4 or is my code for SATA5/6 not consistent with the existing behavior of 1-4?

@LPJon
Copy link
Author

LPJon commented Feb 29, 2024

@DanielGibson I also made those changes for 1-4. Your code is consistent. I just changed it to my liking.

@mafredri
Copy link
Owner

Unless I missed something, I think we made all the necessary changes to the code thanks to Daniel. Thanks for your report @LPJon.

PS. You can change the behavior without modifying the module:

for i in $(seq 1 6); do
	echo off > /sys/class/leds/sata${i}:green:disk/trigger
	echo disk-activity > /sys/class/leds/sata${i}:red:disk/trigger
done

You could add that to a systemd script that starts at boot or if your system has it, /etc/rc.local. (Or initramfs if you want it to change even earlier.)

@DanielGibson
Copy link
Contributor

Hi @LPJon, could you post the output of
$ sudo lspci -nn
and
$ sudo lspci -tv -nn

I want to make sure my Flashstor detection (#27) doesn't break support for AS6706T :)

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants