-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@engcom-Hotel Reproduced #39206 issue in 2.4.7-p1 #39530
Comments
Hi @senthilengg. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Update indexer hash up on Creation of new encryption key
Updating indexer state hash upon creation of new encryption key from admin
…ssue-39530 Fix for issue magento#39530 to avoid regenerating admin grid flat table
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hello @senthilengg, Thanks for the report and collaboration! We have tried to follow the mentioned steps and for us, the Previously it was something like below: After running The Thanks |
@engcom-Hotel Its not only updating the hash of the indexer but also regenerate the whole grid data again. Assume a situation if you have 4 million customer data and the grid table got truncated and recreated then it introduces significant downtime for no use. Ideally the encryption key should update the hash alone and not the grid data because there is no business need to do that and it creates a huge downtime for the merchants if they have million plus customers. Expected Result : Hash should update on the indexer_state without regenerating the grid data. |
Hello @senthilengg, After looking into the codebase, we haven’t found any indication that the After encryption key changes, data that depends on encrypted values might become stale and require reindexing. Magento will update the indexer_state table for any indexers that need reindexing. Thanks |
@engcom-Hotel if you read carefully I have mentioned its regenerating the grid data customer grid, sales ordergrid etc. Indexer state suppose to be update but not the customer grid data which will create a huge downtime for the customer during the next setup:upgrade. |
@engcom-Hotel i have also submitted a PR to fix the issue, once you are able to confirm the issue please help review the PR as well. Thank you |
@engcom-Hotel I am able to reproduce the same issue in 2.4.7-p1.
Steps to Reproduce
Here is the indexer status from my local before and after
I would suggest re-open the issue
Originally posted by @senthilengg in #39206 (comment)
The text was updated successfully, but these errors were encountered: