Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a crate compatible with latest Rocket.rs #1

Open
manio opened this issue Aug 13, 2020 · 3 comments
Open

Make a crate compatible with latest Rocket.rs #1

manio opened this issue Aug 13, 2020 · 3 comments

Comments

@manio
Copy link

manio commented Aug 13, 2020

Hi!
The crate is not compatible with recent master version of rocket (probably v0.5) which has the async runtime.
Could you please add this support?

Currently I have compilation error:

error[E0053]: method `authorizing` has an incompatible type for trait
  --> src/main.rs:44:5
   |
44 |     fn authorizing(request: &'a Request<'r>, authorization: Option<&'a str>) -> Option<Self> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rocket::request::request::Request`, found struct `rocket::Request`
   |
   = note: expected fn pointer `fn(&'a rocket::request::request::Request<'r>, std::option::Option<_>) -> std::option::Option<_>`
              found fn pointer `fn(&'a rocket::Request<'r>, std::option::Option<_>) -> std::option::Option<_>`
   = note: perhaps two different versions of crate `rocket` are being used?

Steps to reproduce:
Change a rocket to git version in Cargo.toml:
rocket = { git = "https://github.com/SergioBenitez/Rocket" }
and set in project's [package] section:
edition = "2018"

ps. maybe this code would be useful when doing transition:
https://github.com/Weasy666/rocket_airlock

@magiclen
Copy link
Owner

This crate and my other crates related to Rocket will support Rocket 0.5 when it releases.

@magiclen
Copy link
Owner

The master branch currently supports Rocket 0.5.0-dev. I'm looking forward to the release of Rocket 0.5.

@magiclen
Copy link
Owner

magiclen commented Apr 8, 2023

It's 2023 now. The Rocket 0.5 has not released yet, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants