Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Sponsor badges are a bit strong #357

Closed
weex opened this issue Dec 22, 2021 · 8 comments
Closed

Problem: Sponsor badges are a bit strong #357

weex opened this issue Dec 22, 2021 · 8 comments

Comments

@weex
Copy link
Member

weex commented Dec 22, 2021

The badge is pretty big and filled with a solid color that stands out quite strongly.

Proposed solution:
Mute color slightly and go with outline only.

@weex weex added the critical label Dec 27, 2021
@Mansh05
Copy link

Mansh05 commented Dec 28, 2021

How about the badges similar to the one below.
Screen Shot 2021-12-28 at 4 40 45 PM

@weex
Copy link
Member Author

weex commented Dec 28, 2021

If it's like emoji sized that would do it for me. Part of the issue is that it seems hard to modify the styling. Maybe a configurable emoji or custom emoji with 🥈🥇🥉used for the default packages.

@Mansh05
Copy link

Mansh05 commented Dec 28, 2021

Sounds good @weex, I will add db column so that we can mention the color of the badge. We can just have one styling but the color changes based on the value provided in the db.

Mansh05 added a commit to Mansh05/ecko that referenced this issue Jan 3, 2022
@Mansh05
Copy link

Mansh05 commented Jan 3, 2022

Creating a new issue for customizable emoji in the plugin repo. here

weex added a commit that referenced this issue Jan 3, 2022
@Mansh05
Copy link

Mansh05 commented Jan 5, 2022

@weex can we close this? #369 solves this.

@weex
Copy link
Member Author

weex commented Jan 5, 2022

Just want to confirm it somewhere. c4.social is the easiest place once I can update it.

@weex weex removed the critical label Jan 5, 2022
weex pushed a commit to weex/ecko that referenced this issue Jan 6, 2022
@Mansh05
Copy link

Mansh05 commented Jan 16, 2022

@weex I think we should close this since its been handled #369. If you think we should keep it open than please reopen it. I will close it for now.

@Mansh05 Mansh05 closed this as completed Jan 16, 2022
@weex
Copy link
Member Author

weex commented Jan 16, 2022

Yep, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants