-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fastutil serializers #76
Comments
Looking forward to the results of your test ;-) |
snerk nicely played. I'll get there. |
Vanilla kryo 5.1.1 selects
Serialized class contains: private final Object2IntMap<String> testField;
public Test(String someParam) {
testField = new Object2IntOpenHashMap<String>();
// fill in some data
} I guess fastutil needs custom serializer that takes precedence over default collection serializers. How is everyone dealing with this? Are people adding the entire Apache Giraph core as a dependency? Or is everyone adding an override for all fastutil classes/interfaces that forces use of BTW, is this project alive? There have been no commits for 2 years. |
My current workaround is this: kryo.addDefaultSerializer(Object2IntMap.class, new JavaSerializer(); This has to be done for every top-level interface in fastutil. This could be added to kryo-serializers. |
I could do a quick pull request copying Giraph code if there is someone around to merge it. |
I should test to figure out whether this is actually required or not. If fastutil serializes by default, then this ticket was a waste of your time.
https://github.com/apache/giraph/blob/4f9c6c24a8b4b03e2836c77fe2e53e38b6519420/giraph-core/src/main/java/org/apache/giraph/writable/kryo/serializers/FastUtilSerializer.java
interesting strategy, but works.
The text was updated successfully, but these errors were encountered: