Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer-to-peer - John #3

Closed
Rysth opened this issue Jun 6, 2023 · 1 comment
Closed

Peer-to-peer - John #3

Rysth opened this issue Jun 6, 2023 · 1 comment

Comments

@Rysth
Copy link

Rysth commented Jun 6, 2023

Opinions (Suggestions/Improvements)

  • Good common CSS structure because of clean code.
  • Good use of semantic HTML tags in general.
  • Use of CSS variables in font names and colors to have more flexibility.
  • Use a better Hierarchy on each HTML page to support SEO guidelines.
  • Change the first div tag on the About Section which has the about-top class name to a header tag.
@mahammad-mostafa
Copy link
Owner

🖊️ Resolved with following actions

✅ Made use of CSS variables across different colors and fonts
✅ Changed first div tag in the about section to a header tag
✅ Added your contribution to the README file Acknowledgements section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahammad-mostafa @Rysth