Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery intermittently breaks in iOS #26

Closed
RichardM99 opened this issue Aug 24, 2018 · 9 comments
Closed

Gallery intermittently breaks in iOS #26

RichardM99 opened this issue Aug 24, 2018 · 9 comments

Comments

@RichardM99
Copy link

Can replicate using the demo app provided in this repo.

Two issues seems to occur intermittently;

  1. When you open the gallery with more than one photo, you are unable to swipe to the next or previous photo.

  2. When swiping, the gallery seems to sometimes lose track of it's current index position. This results in the header text being incorrect (for example if it was "1 of 4" it will now read "1") and also results in missing photos i.e. where once before you could swipe between three photos you can now only swipe between two. For example, the image below has the wrong header as it's the second image

screen shot 2018-08-24 at 09 40 24

To replicate open any of the three galleries in the demo in this repo and start swiping. As mentioned, only happens intermittently so you need to just close and reopen the gallery if the issue does not occur and eventually you will come across the issues mentioned. Android everything seems to be working fine!

Could possibly be related to these issues ?

nytimes/NYTPhotoViewer#260

nytimes/NYTPhotoViewer#259

Let me know what you think!

Cheers

@manijak
Copy link
Owner

manijak commented Aug 24, 2018

Thanks for the detailed feedback, will look into into as soon as I can :)

@RichardM99
Copy link
Author

Thanks for the quick response 👍

@Sbpace
Copy link

Sbpace commented Nov 2, 2018

Hi Manijak,
Do you know when this issue will be fixed? It is causing us some problems.

@manijak
Copy link
Owner

manijak commented Nov 2, 2018

No ETA. Feel free to fork the repo and see if you could fix the issue yourself. PRs are welcome.

@Sbpace
Copy link

Sbpace commented Nov 2, 2018

Thanks for the quick reply. We will take a look at the issue 👍

manijak added a commit that referenced this issue Jan 5, 2019
@manijak manijak closed this as completed Jan 18, 2019
@RichardM99
Copy link
Author

I have tested this using npm version 1.5.0 and still experiencing the same issue.

@miex0r @manijak

Could it be an issue with the version published on npm maybe ?

@manijak manijak reopened this Mar 18, 2019
@manijak manijak closed this as completed Mar 18, 2019
@RichardM99
Copy link
Author

@manijak Hey thanks for taking another look. Are the latest changes published to npm ?

@manijak
Copy link
Owner

manijak commented Mar 19, 2019

No not yet, need to make sure Android part still works, pluss update demos and readme. There will be a few breaking changes with the new version, but it will work better.

@RichardM99
Copy link
Author

Thanks for the reply 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants