-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery intermittently breaks in iOS #26
Comments
Thanks for the detailed feedback, will look into into as soon as I can :) |
Thanks for the quick response 👍 |
Hi Manijak, |
No ETA. Feel free to fork the repo and see if you could fix the issue yourself. PRs are welcome. |
Thanks for the quick reply. We will take a look at the issue 👍 |
@manijak Hey thanks for taking another look. Are the latest changes published to npm ? |
No not yet, need to make sure Android part still works, pluss update demos and readme. There will be a few breaking changes with the new version, but it will work better. |
Thanks for the reply 👍 |
Can replicate using the demo app provided in this repo.
Two issues seems to occur intermittently;
When you open the gallery with more than one photo, you are unable to swipe to the next or previous photo.
When swiping, the gallery seems to sometimes lose track of it's current index position. This results in the header text being incorrect (for example if it was "1 of 4" it will now read "1") and also results in missing photos i.e. where once before you could swipe between three photos you can now only swipe between two. For example, the image below has the wrong header as it's the second image
To replicate open any of the three galleries in the demo in this repo and start swiping. As mentioned, only happens intermittently so you need to just close and reopen the gallery if the issue does not occur and eventually you will come across the issues mentioned. Android everything seems to be working fine!
Could possibly be related to these issues ?
nytimes/NYTPhotoViewer#260
nytimes/NYTPhotoViewer#259
Let me know what you think!
Cheers
The text was updated successfully, but these errors were encountered: